make addDisposer public #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Nov 8, 2022
dumi/docs/concepts/state/index.md
Outdated
| /** Do dispose. */ | ||
| dispose(): void | ||
| /** Collect the disposer function. */ | ||
| addDisposer(disposer: Disposer): void |
There was a problem hiding this comment.
这个是需要加到 IState 上的吗？以及我看 IState 对应的代码并还没有加？
There was a problem hiding this comment.
有道理 现在加了 4420cd3
加之前就能用是因为实际上都 extends 了 Disposable
There was a problem hiding this comment.
加之前就能用是因为实际上都 extends 了 Disposable
那是不是说明在具体的实现（FieldState、FormState、..）上有 addDisposer 平时就够用了，而不一定要体现在接口上？
体现在接口上的话会给每个对接口的实现（包括当下的跟将来的）增加负担
There was a problem hiding this comment.
也行
不过文档哪里适合写这个呢（哪些有 add disposer）
There was a problem hiding this comment.
不过文档哪里适合写这个呢（哪些有 add disposer）
不用写在文档里吧，自己通过 TS 的类型就能发现；事实上是绝大部分内置的 class XxxState 都有 addDisposer？
There was a problem hiding this comment.
事实上是绝大部分内置的
class XxxState都有addDisposer
对
nighca
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case: add disposer (sth like mobx reaction) in react hooks
resolve react dev version