Skip to content

make addDisposer public #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2022
Merged

make addDisposer public #88

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1182849
make addDisposer public
lzfee0227 Nov 8, 2022
2c18e56
resolve react version
lzfee0227 Nov 8, 2022
76bc09d
doc add dispose
lzfee0227 Nov 8, 2022
4420cd3
add addDisposer to IState
lzfee0227 Nov 8, 2022
5b62d98
remove addDisposer from IState
lzfee0227 Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove addDisposer from IState
  • Loading branch information
@lzfee0227
lzfee0227 committed Nov 8, 2022
commit 5b62d986d924c8dd01ba31fd84a842dd4708249d
2 changes: 0 additions & 2 deletions dumi/docs/concepts/state/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ export interface IState<V> {
disableWhen(predictFn: () => boolean): this
/** Do dispose. */
dispose(): void
/** Collect the disposer function. */
addDisposer(disposer: Disposer): void
}
```

Expand Down
2 changes: 0 additions & 2 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ export interface IState<V = unknown> {
disableWhen(predictFn: () => boolean): this
/** Do dispose */
dispose(): void
/** Collect the disposer function */
addDisposer(disposer: Disposer): void
}

/** Function to do dispose. */
Expand Down