Skip to content

Fix SnapshotSchedule tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Fix SnapshotSchedule tests #3

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa42b5c
Improve SnapshotSchedule tests
sklarsa Jun 21, 2023
dbbf17b
Merge branch 'main' into steve/fixes-sched-tests
sklarsa Jun 21, 2023
3fed8c1
typo
sklarsa Jun 21, 2023
795e0d8
found usage of normal time instead of abtime
sklarsa Jun 21, 2023
d0b56be
add another retry
sklarsa Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add another retry
  • Loading branch information
@sklarsa
sklarsa committed Jun 21, 2023
commit d0b56be5030d878d7c48ce4c98edeac0fed5cf0d
20 changes: 11 additions & 9 deletions internal/controller/questdbsnapshotschedule_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,18 @@ var _ = Describe("QuestDBSnapshotSchedule Controller", func() {
g.Expect(k8sClient.Update(ctx, sched)).To(Succeed())
}, timeout, interval).Should(Succeed())

By("Setting the status of the latest snapshot to Succeeded")
snapList := &crdv1beta1.QuestDBSnapshotList{}
Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
Expect(snapList.Items).To(HaveLen(2))
for _, snap := range snapList.Items {
if snap.Status.Phase != crdv1beta1.SnapshotSucceeded {
snap.Status.Phase = crdv1beta1.SnapshotSucceeded
Expect(k8sClient.Status().Update(ctx, &snap)).To(Succeed())
By("Setting the status of all snapshots to Succeeded")
Eventually(func(g Gomega) {

snapList := &crdv1beta1.QuestDBSnapshotList{}
g.Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
for _, snap := range snapList.Items {
if snap.Status.Phase != crdv1beta1.SnapshotSucceeded {
snap.Status.Phase = crdv1beta1.SnapshotSucceeded
g.Expect(k8sClient.Status().Update(ctx, &snap)).To(Succeed())
}
}
}
}, timeout, interval).Should(Succeed())

By("Forcing a reconcile")
_, err := r.Reconcile(ctx, ctrl.Request{
Expand Down