Skip to content

Fix SnapshotSchedule tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Fix SnapshotSchedule tests #3

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa42b5c
Improve SnapshotSchedule tests
sklarsa Jun 21, 2023
dbbf17b
Merge branch 'main' into steve/fixes-sched-tests
sklarsa Jun 21, 2023
3fed8c1
typo
sklarsa Jun 21, 2023
795e0d8
found usage of normal time instead of abtime
sklarsa Jun 21, 2023
d0b56be
add another retry
sklarsa Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve SnapshotSchedule tests
  • Loading branch information
@sklarsa
sklarsa committed Jun 21, 2023
commit fa42b5c2c9bb9fc02f82f0b0cbdd160bdabf5018
26 changes: 17 additions & 9 deletions internal/controller/questdbsnapshotschedule_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ var _ = Describe("QuestDBSnapshotSchedule Controller", func() {
timeSource.Advance(time.Minute + 10*time.Second)

By("Forcing a reconcile")
_, err := r.Reconcile(ctx, ctrl.Request{
res, err := r.Reconcile(ctx, ctrl.Request{
NamespacedName: client.ObjectKeyFromObject(sched),
})
Expect(res).To(Equal(ctrl.Result{}))
Expect(err).ToNot(HaveOccurred())

By("Checking that a snapshot has been created")
Expand All @@ -102,9 +103,10 @@ var _ = Describe("QuestDBSnapshotSchedule Controller", func() {
}, timeout, interval).Should(Succeed())

By("Forcing a reconcile")
_, err := r.Reconcile(ctx, ctrl.Request{
res, err := r.Reconcile(ctx, ctrl.Request{
NamespacedName: client.ObjectKeyFromObject(sched),
})
Expect(res).To(Equal(ctrl.Result{}))
Expect(err).ToNot(HaveOccurred())

By("Checking that the status has been updated")
Expand All @@ -117,15 +119,18 @@ var _ = Describe("QuestDBSnapshotSchedule Controller", func() {
timeSource.Advance(time.Minute + 10*time.Second)

By("Forcing a reconcile")
_, err := r.Reconcile(ctx, ctrl.Request{
res, err := r.Reconcile(ctx, ctrl.Request{
NamespacedName: client.ObjectKeyFromObject(sched),
})
Expect(res).To(Equal(ctrl.Result{}))
Expect(err).ToNot(HaveOccurred())

By("Checking that a snapshot has been created")
snapList := &crdv1beta1.QuestDBSnapshotList{}
Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
Expect(snapList.Items).To(HaveLen(2))
Eventually(func(g Gomega) {
snapList := &crdv1beta1.QuestDBSnapshotList{}
g.Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
g.Expect(snapList.Items).To(HaveLen(2))
}, timeout, interval).Should(Succeed())
})

It("should requeue the request to the time of the next trigger", func() {
Expand Down Expand Up @@ -157,14 +162,17 @@ var _ = Describe("QuestDBSnapshotSchedule Controller", func() {
}

By("Forcing a reconcile")
_, err := r.Reconcile(ctx, ctrl.Request{
res, err := r.Reconcile(ctx, ctrl.Request{
NamespacedName: client.ObjectKeyFromObject(sched),
})
Expect(err).ToNot(HaveOccurred())
Expect(res).To(Equal(ctrl.Result{})

By("Checking that a snapshot has been deleted")
Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
Expect(snapList.Items).To(HaveLen(1))
Eventually(func(g Gomega) {
g.Expect(k8sClient.List(ctx, snapList, client.InNamespace(sched.Namespace))).Should(Succeed())
g.Expect(snapList.Items).To(HaveLen(1))
}, timeout, interval).Should(Succeed())
})

})
Expand Down