Fix compose activity infinitely loading#662
Merged
octoshrimpy merged 3 commits intoquik-sms:masterfrom Jan 11, 2026
Merged
Conversation
Inhishonor
force-pushed
the
conversation-loading
branch
from
01a22f3 to
544a605
Compare
In some cases, (mainly on HyperOS and variants) content provider will return null if an empty conversation is created. This was breaking the compose activity as it expects some object other than null. This commit changes the behavior to provide a new conversation object if createConversationFromCp ever returns null.
Inhishonor
force-pushed
the
conversation-loading
branch
from
544a605 to
d1473a6
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, (mainly on HyperOS and variants) content provider will return null if an empty conversation is created. This was breaking the compose activity as it expects some object other than null.
This commit changes the behavior to provide a new conversation object if
createConversationFromCpever returns null. This behavior could have been rolled intocreateConversationFromCpbut I elected for a separate function as that was a tad cleaner, and made things really obvious.While I was hunting for the cause of the infinite loading, I did some minor cleanups and error handling as well.
Closes #616
Closes #560