Fixes #595, #601 Add translations for settings in sidebar #602
Conversation
|
@umairidris you are a kind man! Can I trouble you a little bit more? See: |
|
Sure thing, keep this open I will just add them here. p.s. I am getting these off Google translate. Might want to get someone to confirm them :) |
|
Can you also remove "LANGUAGE" from footer ? and translate "ALL RIGHTS RESERVED " as well. For Urdu this would be: "جملہ حقوق محفوظ ہیں" |
|
Yeah i been using Google translate too |
|
Deployed to: http://staging.quran.com:33181 |
umairidris
changed the title
|
Deployed to: http://staging.quran.com:33182 |
umairidris
changed the title
src/locale/en.js
Outdated
| 'nav.navigate': 'Navigate', | ||
| 'nav.legacySite': 'Legacy Quran.com', | ||
|
|
||
| 'settings.reciters': 'Reciters', |
There was a problem hiding this comment.
You can use setting.reciters for this
src/locale/en.js
Outdated
|
|
||
| 'settings.reciters': 'Reciters', | ||
| 'settings.translations': 'Translations', | ||
| 'settings.tooltip': 'Tooltip Content', |
There was a problem hiding this comment.
setting.tooltip.title
src/locale/ur.js
Outdated
|
|
||
| 'settings.reciters': 'قراء', | ||
| 'settings.translations': 'ترجمہ', | ||
| 'settings.tooltip': 'اوزاری ٹوٹکا مواد', |
There was a problem hiding this comment.
lol اوزاری ٹوٹکا مواد is too much :) no one will understand what's this :p
There was a problem hiding this comment.
Blame Ggogle translate :P any alternative?
There was a problem hiding this comment.
we already have translation for setting, see setting.* group. For tooltip key is setting.tooltip.title
There was a problem hiding this comment.
Ops... I'll fix that
|
Deployed to: http://staging.quran.com:33183 |
|
Deployed to: http://staging.quran.com:33184 |
|
Deployed to: http://staging.quran.com:33185 |
| <a tabIndex="-1" className="pointer" onClick={() => this.setState({ settingsModalOpen: true }, handleOpen(false))}> | ||
| <i className="ss-icon ss-settings vertical-align-middle" />{' '}Settings | ||
| <i className="ss-icon ss-settings vertical-align-middle" />{' '} | ||
| <LocaleFormattedMessage id="nav.settings" defaultMessage="Settings" /> |
There was a problem hiding this comment.
we can use setting.title for this, no need to duplicate keys with same values.
There was a problem hiding this comment.
Wait.. setting.title is set to Quran for some reason
There was a problem hiding this comment.
setting.title is the sidebar title not the "settings" word
There was a problem hiding this comment.
I actually searched for options for urdu/arabic to be safe (so it duplicates setting.option at the moment) because settings in english has two meanings. But in English it should be called settings, not options. If you have alternative word for settings for urdu I can use that instead.
There was a problem hiding this comment.
I believe we had 'Setting' and 'options' two different words in sidebar before. But that's not the case now. We can remove options now.
There was a problem hiding this comment.
value of setting.title should be "Settings", that's bug in en.js. Urdu and Arabic has correct value. Lets use setting.title and remove setting.options
There was a problem hiding this comment.
Done. Drawer was using setting.title so I added a nav.title to replace it.
|
Deployed to: http://staging.quran.com:33186 |
|
Deployed to: http://staging.quran.com:33187 |
|
Deployed to: http://staging.quran.com:33188 |
naveed-ahmad
left a comment
naveed-ahmad
left a comment
There was a problem hiding this comment.
I'm not sure why sidebar header is "Quran". It should be "Setting" OR " put small Quran logo which point to home.
|
Deployed to: http://staging.quran.com:33190 |
|
@naveed-ahmad agreed! |
4 participants
Fixes #595, #601