Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

Fixes #595, #601 Add translations for settings in sidebar #602

Merged
mmahalwy merged 14 commits into from
Jan 20, 2017
Merged

Fixes #595, #601 Add translations for settings in sidebar #602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ee5ae05
Add translations for settings in sidebar
umairidris Jan 20, 2017
b0be20a
new line
umairidris Jan 20, 2017
2a3de9c
More translations
umairidris Jan 20, 2017
575f89a
Periods
umairidris Jan 20, 2017
145446f
Rename settings ids
umairidris Jan 20, 2017
03b8768
Use existing ids which I blindly missed
umairidris Jan 20, 2017
29bfc21
Delete ids from ur.js
umairidris Jan 20, 2017
4ae39ce
Delete ids from en.js
umairidris Jan 20, 2017
58d1906
Fix reciters title for ur/ar
umairidris Jan 20, 2017
aa1c990
Use setting.title
umairidris Jan 20, 2017
3a3ebb7
I should get some sleep
umairidris Jan 20, 2017
c446279
Revert setting.title to nav.settings
umairidris Jan 20, 2017
b406cdf
Remove setting.option, add nav.title
umairidris Jan 20, 2017
cb3152b
Merge branch 'master' into settingstranslations
naveed-ahmad Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More translations
  • Loading branch information
@umairidris
umairidris committed Jan 20, 2017
commit 2a3de9c07d882b24e3b5945e6cb1d1235c18cd04
11 changes: 3 additions & 8 deletions src/components/Footer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,6 @@ const Footer = () => (
</Col>

<Col md={4} sm={12} xs={12} className={styles.links}>
<p className={styles.header}>
<LocaleFormattedMessage
id="local.selectLabel"
defaultMessage="Site Language"
/>
</p>

<div className={styles.list}>
<p className="monserrat">
<LocaleFormattedMessage
Expand All @@ -150,7 +143,9 @@ const Footer = () => (
/>
</p>

<p className="monserrat">&copy; QURAN.COM. ALL RIGHTS RESERVED 2016</p>
<p className="monserrat">
&copy; 2016 Quran.com <LocaleFormattedMessage id="nav.rightsReserved" defaultMessage="All Rights Reserved" />
</p>
</div>
</Col>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/GlobalSidebar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class GlobalSidebar extends Component {
<li>
<a tabIndex="-1" className="pointer" onClick={() => this.setState({ settingsModalOpen: true }, handleOpen(false))}>
<i className="ss-icon ss-settings vertical-align-middle" />{' '}
<LocaleFormattedMessage id="setting.settings" defaultMessage="Settings" />
<LocaleFormattedMessage id="nav.settings" defaultMessage="Settings" />
Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use setting.title for this, no need to duplicate keys with same values.

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait.. setting.title is set to Quran for some reason

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting.title is the sidebar title not the "settings" word

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually searched for options for urdu/arabic to be safe (so it duplicates setting.option at the moment) because settings in english has two meanings. But in English it should be called settings, not options. If you have alternative word for settings for urdu I can use that instead.

Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we had 'Setting' and 'options' two different words in sidebar before. But that's not the case now. We can remove options now.

Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value of setting.title should be "Settings", that's bug in en.js. Urdu and Arabic has correct value. Lets use setting.title and remove setting.options

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Drawer was using setting.title so I added a nav.title to replace it.

</a>
</li>
<li>
Expand Down
15 changes: 11 additions & 4 deletions src/components/SettingsModal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { PropTypes } from 'react';
import { connect } from 'react-redux';
import Modal from 'react-bootstrap/lib/Modal';

import LocaleFormattedMessage from 'components/LocaleFormattedMessage';
import ReciterDropdown from 'components/ReciterDropdown';
import ContentDropdown from 'components/ContentDropdown';
import TooltipDropdown from 'components/TooltipDropdown';
Expand Down Expand Up @@ -37,26 +38,32 @@ const SettingsModal = ({
<Modal show={open} onHide={handleHide}>
<ModalHeader closeButton>
<ModalTitle className="montserrat">
Settings
<LocaleFormattedMessage id="nav.settings" defaultMessage="Settings" />
</ModalTitle>
</ModalHeader>
<ModalBody>
<div className="form-group">
<h5 className="text-black">Reciters</h5>
<h5 className="text-black">
<LocaleFormattedMessage id="settings.reciters" defaultMessage="Reciters" />
</h5>
<ReciterDropdown
onOptionChange={handleOptionChange}
audio={options.audio}
/>
</div>
<div className="form-group">
<h5 className="text-black">Translations</h5>
<h5 className="text-black">
<LocaleFormattedMessage id="settings.translations" defaultMessage="Translations" />
</h5>
<ContentDropdown
onOptionChange={handleOptionChange}
content={options.content}
/>
</div>
<div className="form-group">
<h5 className="text-black">Tooltip Content</h5>
<h5 className="text-black">
<LocaleFormattedMessage id="settings.tooltip" defaultMessage="Tooltip Content" />
</h5>
<TooltipDropdown
tooltip={options.tooltip}
onOptionChange={setOption}
Expand Down
6 changes: 6 additions & 0 deletions src/locale/ar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,16 @@ export default {
'nav.contactUs': 'اتصل بنا',
'nav.help': 'مساعدة وتعليقات',
'nav.aboutQuranProject': 'Quran.com المعروف أيضا باسم القرآن الكريم، قناة القرآن الكريم، القرآن الكريم، القرآن الكريم) هو مشروع خيري)', // eslint-disable-line max-len
'nav.rightsReserved': 'كل الحقوق محفوظة',
'nav.mobile': 'التليفون المحمول',
'nav.navigate': 'انتقل',
'nav.legacySite': 'الموقع القديم',

'settings.reciters': 'القراء',
'settings.translations': 'ترجمة',
'settings.tooltip': 'المحتوى تلميح الأدوات',


'login.message': 'تسجيل الدخول إلى Quran.com لتخزين كل ما تبذلونه من العناوين والملاحظات والأنشطة.'
}
};
5 changes: 5 additions & 0 deletions src/locale/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,15 @@ export default {
'nav.contactUs': 'Contact us',
'nav.help': 'Help & feedback',
'nav.aboutQuranProject': 'Quran.com (also known as The Noble Quran, Al Quran, Holy Quran, Koran) is a pro bono project.', // eslint-disable-line max-len
'nav.rightsReserved': 'All Rights Reserved',
'nav.mobile': 'Mobile Apps',
'nav.navigate': 'Navigate',
'nav.legacySite': 'Legacy Quran.com',

'settings.reciters': 'Reciters',
Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use setting.reciters for this

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

'settings.translations': 'Translations',
'settings.tooltip': 'Tooltip Content',
Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting.tooltip.title

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


'login.message': 'Sign in to Quran.com to store all your bookmarks, notes and activities.'
}
};
8 changes: 7 additions & 1 deletion src/locale/ur.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default {
'actions.play': 'چلاو',
'actions.pause': 'روک دیں',

'nav.settings', 'اختیارات',
'nav.settings': 'اختیارات',
'nav.contribute': 'تعاون کریں',
'nav.aboutUs': 'ہمارے متعلق',
'nav.developers': 'ڈویلپرز',
Expand All @@ -70,10 +70,16 @@ export default {
'nav.contactUs': 'ہم سے رابطہ',
'nav.help': 'مدد اور تاثرات',
'nav.aboutQuranProject': 'قرآن کریم ایک فلاں عامہ (عوامی بہبود کے لئے) منصوبہ ہے',
'nav.rightsReserved': 'جملہ حقوق محفوظ ہیں',
'nav.mobile': 'موبائل',
'nav.navigate': 'تشریف لے جائیں',
'nav.legacySite': 'پرانی سائٹ',

'settings.reciters': 'قراء',
'settings.translations': 'ترجمہ',
'settings.tooltip': 'اوزاری ٹوٹکا مواد',
Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol اوزاری ٹوٹکا مواد is too much :) no one will understand what's this :p

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blame Ggogle translate :P any alternative?

Copy link
Contributor

@naveed-ahmad naveed-ahmad Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have translation for setting, see setting.* group. For tooltip key is setting.tooltip.title

Copy link
Contributor Author

@umairidris umairidris Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops... I'll fix that



'login.message': 'Quran.com کرنے کیلئے سائن ان سب کو اپنے بک مارکس، نوٹوں اور سرگرمیوں کو ذخیرہ کرنے.'
}
};