This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Persian language for quran.com-frontend #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persian language for quran.com-frontend locale fully translated from English file within the project.
mmahalwy
approved these changes
Oct 26, 2017
Contributor
mmahalwy
left a comment
mmahalwy
left a comment
There was a problem hiding this comment.
Thank you @kakajan for doing this! @naveed-ahmad looks good?
naveed-ahmad
suggested changes
Oct 26, 2017
Contributor
naveed-ahmad
left a comment
naveed-ahmad
left a comment
There was a problem hiding this comment.
@kakajan please add fr: 'فارسی' to available locales.
https://github.com/quran/quran.com-frontend/blob/master/src/config.js#L32
Contributor
Author
|
Dear @naveed-ahmad I added fa: 'فارسی' to available locales in config.js file and sent another pull request. |
Contributor
|
Deployed to: http://staging.quran.com:32850 |
Contributor
|
Deployed to: http://staging.quran.com:32852 |
Contributor
|
@kakajan thank you, looks good. We need to add missing keys for( Tafsir and Select Tafsir ) for all languages. Next PR maybe? |
naveed-ahmad
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assalamu alaykum,
I just wanted to add Persian language for visitors with Persian language that may increase their interaction with Quran.com.
Jazakum Allah khair
your brother Usher (kakajan).