Updates package_files to filter empty strings #775
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error while trying to compile an roxygenized package in Windows when the Collate directive was added to the DESCRIPTION file. The problem is that the
package_filesfunction returns the path to the directory if there are leading whitespaces in the DESCRIPTION file.I would recommend to change the
scanfunction for regular expressions as they are safer and have full control under the string.For example, if
then;
If we pass this paths to the
tokenize_filefunction, it will throw an error. I propose: