Skip to content

Updates package_files to filter empty strings #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JhossePaul wants to merge 1 commit into from
Closed

Updates package_files to filter empty strings #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updates package_files to filter empty strings 
scan(..., sep = " ") will create empty strings if there are leading whitespaces in the DESCRIPTION file, thus generating an error when trying to apply tokenize_file to unexisting files. Using regular expressions because they are safer than scan
  • Loading branch information
@JhossePaul
JhossePaul authored Aug 9, 2018
commit 7c5af87ba3d716a91498b499613088156cd305dd
3 changes: 1 addition & 2 deletions R/source.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package_files <- function(path) {

all <- normalizePath(r_files(path))

collate <- scan(text = desc$Collate %||% "", what = "", sep = " ",
quiet = TRUE)
collate <- unlist(strsplit(gsub("'", "", desc$Collate), "\\n\\s*"))

collate <- normalizePath(file.path(path, 'R', collate))

Expand Down