chore: upgrade to 1.14.0 #178

chungquantin · 2024-08-12T08:24:09Z

Link to issue: #141

Upgrade guidelines

Each pull request will be merged after two approvals from the reviewers
After merging the version major.minor.patch to developer, the next major.<minor + 1>.patch will be rebased to developer and asking for approvals from the reviewers again.

List of pull requests (merge in order)

1.7.0 to 1.8.0: chore: upgrade to 1.8.0 #177
1.8.0 to 1.9.0: chore: upgrade to 1.9.0 #179
1.9.0 to 1.10.0: chore: upgrade to 1.10.0 #182
1.10.0 to 1.11.0: chore: upgrade to 1.11.0 #189
1.11.0 to 1.12.0: chore: upgrade to 1.12.0 #193
1.12.0 to 1.13.0: chore: upgrade to 1.13.0 #194
1.13.0 to 1.14.0: chore: upgrade v1.14.0 #198 (expect integration test CI issue will be resolved)

Upgrade Polkadot version from 1.7.0 to 1.8.0

codecov-commenter · 2024-08-12T08:54:29Z

Codecov Report

Attention: Patch coverage is 2.66667% with 73 lines in your changes missing coverage. Please review.

Project coverage is 6.40%. Comparing base (a9de17d) to head (835cad2).
Report is 1 commits behind head on main.

Files	Patch %	Lines
node/src/service.rs	0.00%	30 Missing ⚠️
node/src/command.rs	0.00%	13 Missing ⚠️
runtime/devnet/src/lib.rs	7.69%	12 Missing ⚠️
runtime/testnet/src/lib.rs	9.09%	10 Missing ⚠️
runtime/devnet/src/extensions.rs	0.00%	5 Missing ⚠️
runtime/testnet/src/extensions.rs	0.00%	3 Missing ⚠️

@@            Coverage Diff            @@
##             main    #178      +/-   ##
=========================================
- Coverage   10.60%   6.40%   -4.20%     
=========================================
  Files          27      27              
  Lines        2132    1997     -135     
  Branches     2132    1997     -135     
=========================================
- Hits          226     128      -98     
+ Misses       1906    1869      -37

Files	Coverage Δ
node/src/chain_spec.rs	`0.00% <ø> (ø)`
node/src/cli.rs	`0.00% <ø> (ø)`
runtime/devnet/src/config/contracts.rs	`60.00% <ø> (ø)`
runtime/devnet/src/config/xcm.rs	`0.00% <ø> (ø)`
runtime/testnet/src/config/contracts.rs	`60.00% <ø> (ø)`
runtime/testnet/src/config/xcm.rs	`0.00% <ø> (ø)`
runtime/testnet/src/extensions.rs	`0.00% <0.00%> (ø)`
runtime/devnet/src/extensions.rs	`0.00% <0.00%> (ø)`
runtime/testnet/src/lib.rs	`3.89% <9.09%> (-10.99%)`	⬇️
runtime/devnet/src/lib.rs	`3.89% <7.69%> (-10.99%)`	⬇️
... and 2 more

Upgrade Polkadot version from 1.7.0 to 1.8.0

Co-authored-by: Peter White <[email protected]>

Daanvdplas

Well done Tin! We are almost there! I left a few last things two check and I think we forgot the storage reclaim.

Some of the non-polkadot-sdk dependencies are not on the correct version. If you could compare them with the base-parachain on 1.14.

node/src/command.rs

runtime/devnet/build.rs

runtime/devnet/src/lib.rs

integration-tests/src/chains/asset_hub_paseo/mod.rs

integration-tests/src/lib.rs

node/Cargo.toml

node/src/command.rs

runtime/devnet/build.rs

Daanvdplas

LGTM!

Daanvdplas

I'm getting an error when using try-runtime

Daanvdplas · 2024-08-21T14:00:56Z

I'm afraid there are multiple migrations required for pallet contracts. Automatic migration is what we are doing now and can only happen with single migrations.

Edit: the pallet version is 15 so there should only be needed one (ED deposit migration)

Not sure why it doesn't work

al3mart · 2024-08-21T17:11:01Z

#222 Fixed the above.

Daanvdplas · 2024-08-22T08:28:39Z

runtime/devnet/src/extensions.rs

 	// from contract layer to substrate layer.
-	// reference: https://github.com/paritytech/ink-examples/blob/b8d2caa52cf4691e0ddd7c919e4462311deb5ad0/psp22-extension/runtime/psp22-extension-example.rs#L236
-	let overhead = contract_host_weight.debug_message;
+	// reference: https://github.com/paritytech/polkadot-sdk/pull/4233/files#:~:text=DebugMessage(len)%20%3D%3E%20T%3A%3AWeightInfo%3A%3Aseal_debug_message(len)%2C


Great work updating those references Tin!

thank you 🙏

Co-authored-by: Peter White <[email protected]> Co-authored-by: Daanvdplas <[email protected]> Co-authored-by: Alejandro Martinez Andres <[email protected]>

chore: upgrade to 1.8.0 (#177)

a05d9e7

Upgrade Polkadot version from 1.7.0 to 1.8.0

chore(v1.8.0): add missing FungibleAdapter migration

9b5c9cd

chungquantin self-assigned this Aug 13, 2024

chungquantin added the pending label Aug 14, 2024

chungquantin added 3 commits August 15, 2024 17:28

chore: upgrade to 1.9.0 (#179)

d96b93e

Merge branch 'main' into developer

edde558

chore: upgrade to 1.8.0 (#177)

389a2b9

Upgrade Polkadot version from 1.7.0 to 1.8.0

chungquantin added the high priority label Aug 15, 2024

chore: upgrade to 1.10.0 (#182)

620a857

chungquantin changed the title ~~chore: upgrade to 1.14.0~~ chore: final upgrade to 1.14.0 Aug 15, 2024

chungquantin added 2 commits August 16, 2024 15:17

chore: upgrade to 1.11.0 (#189)

2170af7

chore: upgrade to 1.12.0 (#193)

8eeadec

chungquantin requested review from al3mart and peterwht and removed request for al3mart and peterwht August 17, 2024 05:03

chore: upgrade to 1.13.0 (#194)

d7a9bea

chungquantin changed the title ~~chore: final upgrade to 1.14.0~~ chore: upgrade to 1.14.0 Aug 17, 2024

chore: upgrade v1.14.0 (#198)

84cf750

Co-authored-by: Peter White <[email protected]>

Daanvdplas self-requested a review August 21, 2024 07:43

Merge branch 'main' into developer

549a4d1

chungquantin added ready-for-high-level-review and removed pending labels Aug 21, 2024

Daanvdplas reviewed Aug 21, 2024

View reviewed changes

node/src/command.rs Show resolved Hide resolved

node/src/command.rs Show resolved Hide resolved

runtime/devnet/build.rs Show resolved Hide resolved

runtime/devnet/src/lib.rs Show resolved Hide resolved

runtime/devnet/src/lib.rs Show resolved Hide resolved

Daanvdplas and others added 2 commits August 21, 2024 10:36

fmt

2b05c1f

fix: add missing extension for pov reclaim

096b0bb

chungquantin requested review from al3mart, evilrobot-01 and peterwht August 21, 2024 08:56

chungquantin commented Aug 21, 2024

View reviewed changes

integration-tests/src/chains/asset_hub_paseo/mod.rs Show resolved Hide resolved

integration-tests/src/lib.rs Show resolved Hide resolved

node/Cargo.toml Show resolved Hide resolved

node/src/command.rs Show resolved Hide resolved

runtime/devnet/build.rs Show resolved Hide resolved

chungquantin added 2 commits August 21, 2024 16:06

chore: bump dependencies

6ca7817

chore: bump dependencies

835cad2

Daanvdplas self-requested a review August 21, 2024 10:36

Daanvdplas approved these changes Aug 21, 2024

View reviewed changes

Daanvdplas self-requested a review August 21, 2024 13:06

Daanvdplas requested changes Aug 21, 2024

View reviewed changes

fix: missing migration (#222)

b36e426

Daanvdplas approved these changes Aug 21, 2024

View reviewed changes

al3mart approved these changes Aug 21, 2024

View reviewed changes

al3mart merged commit b1394e3 into main Aug 21, 2024

al3mart deleted the developer branch August 21, 2024 18:48

Daanvdplas reviewed Aug 22, 2024

View reviewed changes

chungquantin added a commit that referenced this pull request Sep 6, 2024

chore: upgrade to 1.14.0 (#178)

7ef0f55

Co-authored-by: Peter White <[email protected]> Co-authored-by: Daanvdplas <[email protected]> Co-authored-by: Alejandro Martinez Andres <[email protected]>

chore: upgrade to 1.14.0 #178

chore: upgrade to 1.14.0 #178

Uh oh!

Conversation

chungquantin commented Aug 12, 2024 • edited by Daanvdplas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Upgrade guidelines

List of pull requests (merge in order)

Uh oh!

codecov-commenter commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Daanvdplas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Daanvdplas left a comment

Choose a reason for hiding this comment

Uh oh!

Daanvdplas left a comment

Choose a reason for hiding this comment

Uh oh!

Daanvdplas commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

al3mart commented Aug 21, 2024

Uh oh!

Daanvdplas Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

chungquantin Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chungquantin commented Aug 12, 2024 •

edited by Daanvdplas

Loading

codecov-commenter commented Aug 12, 2024 •

edited

Loading

Daanvdplas commented Aug 21, 2024 •

edited

Loading

chungquantin Aug 22, 2024 •

edited

Loading