Skip to content

Profiler RFC #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 12 commits into from
Jul 25, 2019
Merged

Profiler RFC #51

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
317e02a
Profiler RFC
May 22, 2018
dfe022f
Unresolved questions
May 22, 2018
58afaa1
Formatting nits
May 22, 2018
b529613
Organizational tweask
May 22, 2018
1475772
Added an async caveat about actual time
May 22, 2018
7cb55e6
Typofix
May 22, 2018
3e9edf1
Added clarfiication note about how <Profiler> works in production bundle
May 22, 2018
6062c52
Typofix
Jun 9, 2018
b1834f9
Renamed actualTime -> actualDuration and baseTime -> baseDuration
Aug 3, 2018
c263445
Updated note about Profiler experimental release
Aug 3, 2018
a5c38f4
Added interaction-tracking proposal to RFC
Aug 3, 2018
009a0b4
Udpated RFC
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Organizational tweask
  • Loading branch information
Brian Vaughn committed May 22, 2018
commit b5296133dcd79cea337da1cad78feb24fcc571e5
8 changes: 5 additions & 3 deletions text/0000-profiler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@ This is an entirely new component. Adoption can be organic and gradual.

A reactjs.org blog post would be a good initial start.

# Unresolved questions
Perhaps we could provide some sort of discoverability within React DevTools.

How will people use this? The current proposal is kind of low level and would probably benefit from some reusable abstractions being built on top of it that e.g. aggregate/batch render timings.
# Unresolved questions

How will this feature integrate with React DevTools? I have some ideas but nothing concrete yet to share.
* How will people use this? The current proposal is kind of low level and would probably benefit from some reusable abstractions being built on top of it that e.g. aggregate/batch render timings.
* Are the proposed timing metrics sufficiently useful?
* How will this feature integrate with React DevTools? I have some ideas but nothing concrete yet to share.