Skip to content

Fix D555 recovery mode not recognized #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nir-Az merged 2 commits into from
Oct 27, 2025
Merged

Fix D555 recovery mode not recognized #14375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2e1b8
check if not in recovery mode
AviaAv Oct 23, 2025
931ee1f
move recovery check to dds only
AviaAv Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
check if not in recovery mode
  • Loading branch information
@AviaAv
AviaAv committed Oct 23, 2025
commit 7e2e1b8ac1f18c7287f74f0c99a9402a97b645dc
2 changes: 1 addition & 1 deletion src/ds/advanced_mode/advanced_mode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace librealsense
if( dynamic_cast< depth_sensor * >( base ) )
_depth_sensor = base;
}
if( !_depth_sensor )
if( !_depth_sensor && !dynamic_cast<update_device_interface *> (dev) )
Copy link
Collaborator

@Nir-Az Nir-Az Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we run this code on recovery mode? Is it inherent from a recovery device?

Copy link
Contributor Author

@AviaAv AviaAv Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/IntelRealSense/librealsense/blob/80798d48066aa81cfae34f83f6635ca7c57c640d/src/dds/rs-dds-device-proxy.cpp#L421

Calls it, on c'tor of dds_device_proxy

Copy link
Contributor

@OhadMeir OhadMeir Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my message about checking if recovery in rs-dds-device-proxy.
USB recovery devices are not ds_advanced_mode_base (so not trying to initialize), but for DDS we inherit it without knowing in advance if we are a recovery device or not.

Copy link
Contributor Author

@AviaAv AviaAv Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to rs-dds-device-proxy

throw std::runtime_error( "Advanced mode expects camera to have a depth sensor" );

for( size_t i = 0; i < _dev->get_sensors_count(); ++i )
Expand Down
Loading