-
Notifications
You must be signed in to change notification settings - Fork 62
bundle: remove debug logging from the manager auth proxy patch #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Having v=10 dumps sensitive information like tokens, resulting in information leakage if these logs are obtained. The Kubebuilder team also made this fix. They are also using v=0 now. Ref: kubernetes-sigs/kubebuilder#2435 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852 Signed-off-by: Nitin Goyal <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.12 |
|
/hold |
|
/hold cancel |
|
/cherry-pick release-4.12 |
|
@iamniting: new pull request created: #273 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@iamniting: #271 failed to apply on top of branch "release-4.11": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Having v=10 dumps sensitive information like tokens, resulting in information leakage if these logs are obtained. The Kubebuilder team also made this fix. They are also using v=0 now.
Ref: kubernetes-sigs/kubebuilder#2435
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852
Signed-off-by: Nitin Goyal [email protected]