Skip to content

Conversation

@iamniting
Copy link
Member

Having v=10 dumps sensitive information like tokens, resulting in information leakage if these logs are obtained. The Kubebuilder team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Signed-off-by: Nitin Goyal [email protected]

Having v=10 dumps sensitive information like tokens, resulting in
information leakage if these logs are obtained. The Kubebuilder
team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Signed-off-by: Nitin Goyal <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@malayparida2000
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/cherry-pick release-4.12

@iamniting
Copy link
Member Author

/hold

@openshift-merge-robot openshift-merge-robot merged commit 524fda7 into red-hat-storage:main Nov 10, 2022
@iamniting
Copy link
Member Author

/hold cancel

@iamniting
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@iamniting: new pull request created: #273

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting deleted the log branch February 6, 2023 05:01
@iamniting
Copy link
Member Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@iamniting: #271 failed to apply on top of branch "release-4.11":

Applying: bundle: remove debug logging from the manager auth proxy patch
Using index info to reconstruct a base tree...
M	bundle/manifests/odf-operator.clusterserviceversion.yaml
M	config/default/manager_auth_proxy_patch.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/default/manager_auth_proxy_patch.yaml
Auto-merging bundle/manifests/odf-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/odf-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bundle: remove debug logging from the manager auth proxy patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants