Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #271

/assign iamniting

Having v=10 dumps sensitive information like tokens, resulting in
information leakage if these logs are obtained. The Kubebuilder
team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Signed-off-by: Nitin Goyal <[email protected]>
@iamniting iamniting changed the title [release-4.12] bundle: remove debug logging from the manager auth proxy patch Bug 2136852:[release-4.12] bundle: remove debug logging from the manager auth proxy patch Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2136852, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.12.0) matches configured target release for branch (ODF 4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2136852:[release-4.12] bundle: remove debug logging from the manager auth proxy patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@iamniting
Copy link
Member

/test odf-operator-bundle-e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 199797f into red-hat-storage:release-4.12 Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2136852 has been moved to the MODIFIED state.

In response to this:

Bug 2136852:[release-4.12] bundle: remove debug logging from the manager auth proxy patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants