-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Add allowedUnsafeExecution to the global configuration #39573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jamietanna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need to set this as a configuration option - i.e.
renovate/lib/config/options/index.ts
Lines 3085 to 3096 in a23f6b3
| { | |
| name: 'gitNoVerify', | |
| description: | |
| 'Which Git commands will be run with the `--no-verify` option.', | |
| type: 'array', | |
| subType: 'string', | |
| allowString: true, | |
| allowedValues: ['commit', 'push'], | |
| default: ['commit', 'push'], | |
| stage: 'global', | |
| globalOnly: true, | |
| }, |
|
Couple of tweaks but on the right lines! |
|
As a new global self-hosted configuration item, the build will also fail because we need to capture it in |
|
thanks for the review @jamietanna I can get the rest done now that we're aligned on the implementation. One question for you though: this change is not going to be backwards compatible, ie: as soon as it's released it'll break the gradlew commands that were previously running. Is that fine? Or should it always assume that the gradlewExecution command is there by default? |
|
I'll take more of a look tomorrow :) In terms of the overall implementation, I'm thinking that (IMO)
|
|
Oh also, please remove the |
|
Now #39456 is merged, we can link to that from these docs, too |
|
Thanks for your review. Appreciate your patience as I learn your contribution expectations. |
|
Sorry :D Should be fixed now |
As part of renovatebot#39458, we want to introduce a new self-hosetd configuration item, to restrict what commands can be run as part of artifact upgrades.
030edcd to
b34a6fb
Compare
|
And finally fixed 😅 |
|
🎉 This PR is included in version 42.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@mglazer apologies, this won't quite work yet! As I found while looking at something else, you'll need to add this into |
|
ya...I found that out pretty quickly when I was testing. Updated my other PR for that, but happy to split it up into an isolated PR if you'd prefer that. |
Yeah if you wouldn't mind as a separate PR (with a I'm working out what we need to do to make this something we can't forget to do via #39669 |
Missed when doing: renovatebot#39573
fix: Add `allowedUnsafeExecutions` to GlobalConfig OPTIONS Missed when doing: #39573
Changes
Skeleton implementation for #39458 which adds the initial types necessary to enable guarding which automatic executions can run as part of an artifact upgrade.
Context
Please select one of the following:
allowedUnsafeExecutions#39458AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Could not run this as this doesn't actually change any functionality yet.