fix(global): ensure that all globalOnly options can be set with Global Config
#39669
+123
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
commented
Dec 1, 2025
jamietanna
commented
Dec 1, 2025
lib/config/global.spec.ts
Outdated
|
|
||
| // HACK | ||
| const defined = (GlobalConfig as any).OPTIONS; | ||
| console.log(globalOnlyOptions); |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| console.log(globalOnlyOptions); |
zharinov
approved these changes
Dec 1, 2025
jamietanna
commented
Dec 2, 2025
lib/config/global.spec.ts
Outdated
| import { getOptions } from './options'; | ||
|
|
||
| describe('config/global', () => { | ||
| it('all', () => { |
…bal Config As part of #9603, we intended to come back and make sure that all of our `globalOnly` configuration fields are set here, so they can be correctly updated by configuration (in various forms). As some configuration may not work if we do not set this, we should make sure that this is applied, as well as ensuring that there is a test to catch this requirement.
viceice
requested changes
Dec 2, 2025
Contributor
Author
|
OK fair - so this is maybe the inverse? We should be making sure that |
12 tasks
Contributor
Author
|
We should re-review this (when we come round to it) to determine if #24115 has any pointers to things that should (not) be included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As part of #9603, we intended to come back and make sure that all of our
globalOnlyconfiguration fields are set here, so they can be correctlyupdated by configuration (in various forms).
As some configuration may not work if we do not set this, we should make
sure that this is applied, as well as ensuring that there is a test to
catch this requirement.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
GPT-4.1
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: