Skip to content

fix(global): ensure that all globalOnly options can be set with Global Config #39669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jamietanna wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(global): ensure that all globalOnly options can be set with Global Config #39669

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3a8b27
fix(global): ensure that all `globalOnly` options can be set with Glo…
jamietanna Dec 1, 2025
a403a2d
sq
jamietanna Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
sq
  • Loading branch information
@jamietanna
jamietanna committed Dec 2, 2025
commit a403a2d30d33de993205a1c0a32d3c3c8e5edda3
1 change: 0 additions & 1 deletion lib/config/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
} from './types';

export class GlobalConfig {
// TODO: once global config work is complete, add a test to make sure this list includes all options with globalOnly=true (#9603)
static OPTIONS: readonly (keyof RepoGlobalConfig | keyof GlobalOnlyConfig)[] =
[
'allowCustomCrateRegistries',
Expand All @@ -23,20 +22,20 @@
'autodiscoverRepoSort',
'autodiscoverTopics',
'baseDir',
'bbUseDevelopmentBranch',

Check failure on line 25 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"bbUseDevelopmentBranch"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 25 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"bbUseDevelopmentBranch"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'binarySource',
'cacheDir',
'cacheHardTtlMinutes',
'cachePrivatePackages',
'cacheTtlOverride',
'checkedBranches',

Check failure on line 31 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"checkedBranches"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 31 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"checkedBranches"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'configFileNames',
'configValidationError',

Check failure on line 33 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"configValidationError"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 33 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"configValidationError"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'containerbaseDir',
'customEnvVariables',
'deleteAdditionalConfigFile',
'deleteConfigFile',
'detectGlobalManagerConfig',

Check failure on line 38 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"detectGlobalManagerConfig"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 38 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"detectGlobalManagerConfig"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'detectHostRulesFromEnv',
'dockerChildPrefix',
'dockerCliOptions',
Expand All @@ -48,22 +47,22 @@
'endpoint',
'executionTimeout',
'exposeAllEnv',
'force',

Check failure on line 50 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"force"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 50 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"force"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'forceCli',
'forkCreation',

Check failure on line 52 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"forkCreation"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 52 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"forkCreation"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'forkOrg',

Check failure on line 53 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"forkOrg"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 53 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"forkOrg"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'forkToken',

Check failure on line 54 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"forkToken"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 54 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"forkToken"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'gitNoVerify',
'gitPrivateKey',
'gitPrivateKeyPassphrase',
'gitTimeout',
'gitUrl',

Check failure on line 59 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"gitUrl"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 59 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"gitUrl"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'githubTokenWarn',
'globalExtends',
'httpCacheTtlDays',
'ignorePrAuthor',
'includeMirrors',
'inheritConfig',

Check failure on line 65 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / build 

Type '"inheritConfig"' is not assignable to type '"privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | "allowScripts" | "allowedEnv" | "allowedHeaders" | ... 54 more ... | "deleteAdditionalConfigFile"'.

Check failure on line 65 in lib/config/global.ts

View workflow job for this annotation

GitHub Actions / lint-other 

Type '"inheritConfig"' is not assignable to type '"platform" | "privateKey" | "privateKeyOld" | "gitPrivateKey" | "endpoint" | "localDir" | "cacheDir" | "allowedCommands" | "allowCustomCrateRegistries" | "allowPlugins" | ... 54 more ... | "deleteAdditionalConfigFile"'.
'inheritConfigFileName',
'inheritConfigRepoName',
'inheritConfigStrict',
Expand Down
Loading