fix(npm): yarnDedupeHighest for Yarn 2 #7200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
approved these changes
Sep 7, 2020
Contributor
Author
viceice
reviewed
Sep 8, 2020
Member
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
LGTM, but i think we should improve the docs a little bit more
Comment on lines
1104
to
+1105
| - `yarnDedupeFewer`: Run `yarn-deduplicate --strategy fewer` after `yarn.lock` updates | ||
| - `yarnDedupeHighest`: Run `yarn-deduplicate --strategy highest` after `yarn.lock` updates | ||
| - `yarnDedupeHighest`: Run `yarn-deduplicate --strategy highest` (`yarn dedupe --strategy highest` for Yarn >=2.2.0) after `yarn.lock` updates |
Member
There was a problem hiding this comment.
Should we differentiate more bewteen yarn v1 and v2 here?
|
🎉 This PR is included in version 23.20.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn 2 has introduced
yarn dedupeplugin in yarnpkg/berry#1558. This PR calls it onyarnDedupeHighestpost-update option.Related: #5230.