Skip to content

Conversation

@ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Sep 8, 2020

This is somewhat requirement for #7200, as getLockedVersions only detects whether it's Yarn 1 or greater:

const { lockedVersions, isYarn1 } = await getYarnLock(yarnLock);
lockFileCache[yarnLock] = lockedVersions;
if (!isYarn1) {
packageFile.compatibility.yarn = '>= 2.0.0';
}
unless engines.yarn is set:
} else if (depName === 'yarn') {
dep.datasource = datasourceNpm.id;
dep.commitMessageTopic = 'Yarn';
compatibility.yarn = dep.currentValue;

This PR detects the rough Yarn version using __metadata.cacheKey in yarn.lock.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should think about a better yarn detection, as this becomes more and more complicated with every v2 minor version. 🤔

@rarkins rarkins merged commit 605346f into renovatebot:master Sep 8, 2020
@renovate-release
Copy link

🎉 This PR is included in version 23.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants