Skip to content

Conversation

@henrikblomkvist
Copy link
Contributor

The percent codes are hexadecimal so we can ignore any letters other than a-f.
Any letter aside from these would cause a NumberFormatException when
attempting to decode them.

@weavejester
Copy link
Member

I believe that was intentional; to raise an exception when there was an invalid percent code.

@henrikblomkvist
Copy link
Contributor Author

I believe that was intentional; to raise an exception when there was an invalid percent code.

Aha ok, I saw the suggestion in #7 and didn't see anything further about it, so assumed this had been missed in the following PR. That Pr seemed to only fix 1/3 of the issue URLs raised.

@weavejester
Copy link
Member

Ah, you're correct. Given #8, it makes sense to merge this, as the intent is the same.

@weavejester
Copy link
Member

Can you update the commit message to:

Ensure only hexadecimal percent codes are decoded

This continues the intent of #8, and ensures that only hexadecimal
percent codes are decoded, with anything else ignored.

I think it makes sense to mention #8 for future reference.

This continues the intent of ring-clojure#8, and ensures that only hexadecimal
percent codes are decoded, with anything else ignored.
@henrikblomkvist
Copy link
Contributor Author

Can you update the commit message to:

Ensure only hexadecimal percent codes are decoded

This continues the intent of #8, and ensures that only hexadecimal
percent codes are decoded, with anything else ignored.

I think it makes sense to mention #8 for future reference.

Ok, thanks, that's sorted now.

@weavejester weavejester merged commit 84a7f6f into ring-clojure:master Feb 1, 2023
@weavejester
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants