Skip to content

Conversation

@jcf
Copy link
Member

@jcf jcf commented Mar 12, 2015

We might want to throw an exception to allow users to return a 400 Bad Request… Otherwise, fixes #7 by simply ignoring codes that can't be decoded.

@weavejester
Copy link
Member

This makes sense.

weavejester added a commit that referenced this pull request Mar 16, 2015
Only decode valid percent codes
@weavejester weavejester merged commit b12214f into ring-clojure:master Mar 16, 2015
@jcf
Copy link
Member Author

jcf commented Mar 16, 2015

Thanks @weavejester!

@jcf jcf deleted the strict-url-decoding branch March 16, 2015 17:35
@bcarrell bcarrell mentioned this pull request May 19, 2016
henrikblomkvist added a commit to henrikblomkvist/ring-codec that referenced this pull request Feb 1, 2023
This continues the intent of ring-clojure#8, and ensures that only hexadecimal
percent codes are decoded, with anything else ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumberFormatException from ring.util.codec/percent-decode

2 participants