Fixes #218: Allow rendering description from schema for all fields. #263

amarnus · 2016-07-06T07:00:56Z

Helps with #218

n1k0 · 2016-07-06T07:04:42Z

src/components/fields/SchemaField.js

  return (
    <div className={classList}>
      {displayLabel && label ? getLabel(label, required, id) : null}
+      <DescriptionField id={ `${id}__description` } description={ description } />


nit: {${id}__description} (no space within curly brackets)

n1k0 · 2016-07-06T07:06:19Z

Would you mind adding a few tests? Thanks!

amarnus · 2016-07-06T07:26:13Z

Done.

n1k0 · 2016-07-06T07:27:04Z

test/SchemaField_test.js

+    const schema = {
+      type: "object",
+      properties: {
+        foo: {type: "string",description:"A Foo field"},


nit: missing space after comma

amarnus · 2016-07-06T07:31:59Z

Thanks for highlighting the styling issues. Resolved now. npm run lint didn't catch them though. Will be good to add these rules in there, I feel?

n1k0 · 2016-07-06T07:34:19Z

test/SchemaField_test.js

+      const schema = {
+        type: "object",
+        properties: {
+          foo: {"$ref": "#/definitions/foo"},


nit: $ref (no quotes) works too

n1k0 · 2016-07-06T07:36:18Z

npm run lint didn't catch them though. Will be good to add these rules in there, I feel?

If you know about what the rules to add are, please add them :)

amarnus · 2016-07-06T07:38:13Z

If you know about what the rules to add are, please add them :)

Will do. As another pull request.

…jsf-team#218.

n1k0 · 2016-07-06T07:45:22Z

test/SchemaField_test.js

+
+    it("should render description if available from a referenced schema", () => {
+      // Overriding.
+      const schema = {


I'm surprised you can reassign a const here. You should probably name this specific schema differently instead.

n1k0 · 2016-07-06T07:46:45Z

Side note, please avoid squashing and keep your commits atomic on the PR so I can review them individually. Squashing is enabled for this repo so a single commit will eventually land anyway :)

amarnus · 2016-07-06T07:50:29Z

Noted. It's just that I didn't want the intermediate commits on my fork either. But seeing that you have left comments on them, I guess I shouldn't be squashing them. Got it.

amarnus · 2016-07-06T08:00:18Z

When you have a spare moment later, can restart the Travis build? It failed because of issues with npm.

n1k0 · 2016-07-06T08:01:43Z

Jobs restarted. Edit: restarted again. Edit: npm's broken today it seems.

n1k0 · 2016-07-06T09:09:17Z

test/SchemaField_test.js

+        bar: {type: "string"}
+      }
+    };
+    it("should render description if available from the schema", () => {


nit: insert blank line above this line

n1k0 · 2016-07-06T09:34:34Z

Strange issue with travis it seems, where fetching this url https://registry.npmjs.org/babel-plugin-transform-object-rest-spread/-/babel-plugin-transform-object-rest-spread-6.8.0.tgz fails with a 502 while

$ curl -I https://registry.npmjs.org/babel-plugin-transform-object-rest-spread/-/babel-plugin-transform-object-rest-spread-6.8.0.tgz
HTTP/1.1 200 OK

n1k0 · 2016-07-06T11:31:07Z

Perfect, I'm landing this. Again, thanks for contributing!

* Fixed #217: Implement array field entries reordering (#247) * Fixed corrupted `idSchema` when the schema has a field named id (#262) * Fixed #218: Allow rendering description from schema for all fields. (#263) * Fixed #255: Replace *deeper* dependency with local `deepEquals` helper. (#264)

n1k0 · 2016-07-06T11:48:56Z

Released in v0.36.0.

n1k0 reviewed Jul 6, 2016
View reviewed changes

n1k0 changed the title ~~Allow rendering description from schema for all fields.~~ Fixes #218: Allow rendering description from schema for all fields. Jul 6, 2016

amarnus force-pushed the dev-description branch from b6f2063 to 56bbfef Compare July 6, 2016 07:25

n1k0 reviewed Jul 6, 2016
View reviewed changes

amarnus force-pushed the dev-description branch from 56bbfef to 708b390 Compare July 6, 2016 07:30

n1k0 reviewed Jul 6, 2016
View reviewed changes

Allow rendering of description from schema for all fields. Helps with r…

95c53b9

…jsf-team#218.

amarnus force-pushed the dev-description branch from 708b390 to 95c53b9 Compare July 6, 2016 07:40

n1k0 reviewed Jul 6, 2016
View reviewed changes

Amarnath Ravikumar added 2 commits July 6, 2016 16:31

Insert blank line before a test

3b25b65

Changed name of an overriding const variable

9631b73

n1k0 merged commit 278be64 into rjsf-team:master Jul 6, 2016

Fixes #218: Allow rendering description from schema for all fields. #263

Fixes #218: Allow rendering description from schema for all fields. #263

Uh oh!

Conversation

amarnus commented Jul 6, 2016

Uh oh!

n1k0 Jul 6, 2016

Choose a reason for hiding this comment

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

amarnus commented Jul 6, 2016

Uh oh!

n1k0 Jul 6, 2016

Choose a reason for hiding this comment

Uh oh!

amarnus commented Jul 6, 2016

Uh oh!

n1k0 Jul 6, 2016

Choose a reason for hiding this comment

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

amarnus commented Jul 6, 2016

Uh oh!

n1k0 Jul 6, 2016

Choose a reason for hiding this comment

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

amarnus commented Jul 6, 2016

Uh oh!

amarnus commented Jul 6, 2016

Uh oh!

n1k0 commented Jul 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n1k0 Jul 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

n1k0 commented Jul 6, 2016

Uh oh!

Uh oh!

n1k0 commented Jul 6, 2016 •

edited

Loading

n1k0 Jul 6, 2016 •

edited

Loading