-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixes #218: Allow rendering description from schema for all fields. #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,4 +137,47 @@ describe("SchemaField", () => { | |
.to.have.length.of(1); | ||
}); | ||
}); | ||
|
||
describe("description support", () => { | ||
const schema = { | ||
type: "object", | ||
properties: { | ||
foo: {type: "string", description:"A Foo field"}, | ||
bar: {type: "string"} | ||
} | ||
}; | ||
|
||
it("should render description if available from the schema", () => { | ||
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: insert blank line above this line |
||
const {node} = createFormComponent({schema}); | ||
expect(node.querySelectorAll("div#root_foo__description")) | ||
.to.have.length.of(1); | ||
}); | ||
|
||
it("should render description if available from a referenced schema", () => { | ||
// Overriding. | ||
const schemaWithReference = { | ||
type: "object", | ||
properties: { | ||
foo: {$ref: "#/definitions/foo"}, | ||
bar: {type: "string"} | ||
}, | ||
definitions: { | ||
foo: { | ||
type: "string", | ||
description: "A Foo field" | ||
} | ||
} | ||
}; | ||
const {node} = createFormComponent({schema: schemaWithReference}); | ||
const matches = node.querySelectorAll("div#root_foo__description"); | ||
expect(matches).to.have.length.of(1); | ||
expect(matches[0].textContent).to.equal("A Foo field"); | ||
}); | ||
|
||
it("should not render description if not available from schema", () => { | ||
const {node} = createFormComponent({schema}); | ||
expect(node.querySelectorAll("div#root_bar__description")) | ||
.to.have.length.of(0); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably favor the resolved schema first, what do you think?
Edit: no scratch that you got that right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference, actually. Just kept it consistent with the previous expression that sets the
label
prop.