Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-tauri/src/panel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ pub fn position_panel_at_tray_icon(

let icon_center_x_phys = icon_phys_x + (icon_width_phys / 2);
let panel_x_phys = icon_center_x_phys - (window_width_phys / 2);
let padding_phys = (8.0 * scale_factor).round() as i32;
let padding_phys = (-8.0 * scale_factor).round() as i32;
let panel_y_phys = icon_phys_y + icon_height_phys + padding_phys;

let final_pos = tauri::PhysicalPosition::new(panel_x_phys, panel_y_phys);
Expand Down
42 changes: 22 additions & 20 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -489,27 +489,29 @@ function App() {
}

return (
<div
ref={containerRef}
className="bg-card rounded-lg border shadow-lg overflow-hidden select-none"
style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx}px` } : undefined}
>
<div className="flex h-full min-h-0 flex-row">
<SideNav
activeView={activeView}
onViewChange={setActiveView}
plugins={navPlugins}
/>
<div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0">
<div className="flex-1 min-h-0 overflow-y-auto">
{renderContent()}
</div>
<PanelFooter
version={appVersion}
autoUpdateNextAt={autoUpdateNextAt}
updateStatus={updateStatus}
onUpdateInstall={triggerInstall}
<div ref={containerRef} className="flex flex-col items-center pt-1.5">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low

src/App.tsx:492

The new wrapper's pt-1.5 padding and .tray-arrow height aren't accounted for in maxPanelHeightPx. Consider subtracting the wrapper overhead from the inner card's maxHeight so the footer remains visible when content is tall.

🚀 Want me to fix this? Reply ex: "fix it for me".

<div className="tray-arrow" />
<div
className="bg-card rounded-lg border shadow-lg overflow-hidden select-none w-full"
style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx}px` } : undefined}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Account for arrow height when capping panel

When content reaches the max-height cap, maxPanelHeightPx is applied to the inner panel, but the resize logic now measures the outer wrapper that also includes the new arrow and pt-1.5. That means desiredHeightLogical includes the arrow height, yet window height is still capped to maxHeightPhysical, while html/body/#root have overflow: hidden. In the max-height scenario (e.g., long plugin list), the panel becomes taller than the window by the arrow height, so the bottom rows are clipped and cannot be scrolled to. Consider subtracting the arrow/padding height from the max panel height or moving the max-height constraint to the wrapper so the capped height includes the arrow.

Useful? React with 👍 / 👎.

Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
>
<div className="flex h-full min-h-0 flex-row">
<SideNav
activeView={activeView}
onViewChange={setActiveView}
plugins={navPlugins}
/>
<div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0">
<div className="flex-1 min-h-0 overflow-y-auto">
{renderContent()}
</div>
<PanelFooter
version={appVersion}
autoUpdateNextAt={autoUpdateNextAt}
updateStatus={updateStatus}
onUpdateInstall={triggerInstall}
/>
</div>
</div>
</div>
</div>
Expand Down
22 changes: 22 additions & 0 deletions src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,28 @@ body,
padding: 0;
}

/* Arrow pointing up toward the tray icon */
.tray-arrow {
width: 0;
height: 0;
border-left: 7px solid transparent;
border-right: 7px solid transparent;
border-bottom: 7px solid var(--border);
position: relative;
flex-shrink: 0;
}
.tray-arrow::after {
content: "";
position: absolute;
left: -6px;
top: 1.5px;
width: 0;
height: 0;
border-left: 6px solid transparent;
border-right: 6px solid transparent;
border-bottom: 6px solid var(--card);
}

/* Remove focus rings - this is a menu bar app, not keyboard-navigated */
*:focus,
*:focus-visible {
Expand Down