-
Notifications
You must be signed in to change notification settings - Fork 245
Add upward-pointing arrow to tray panel #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -489,27 +489,29 @@ function App() { | |
| } | ||
|
|
||
| return ( | ||
| <div | ||
| ref={containerRef} | ||
| className="bg-card rounded-lg border shadow-lg overflow-hidden select-none" | ||
| style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx}px` } : undefined} | ||
| > | ||
| <div className="flex h-full min-h-0 flex-row"> | ||
| <SideNav | ||
| activeView={activeView} | ||
| onViewChange={setActiveView} | ||
| plugins={navPlugins} | ||
| /> | ||
| <div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0"> | ||
| <div className="flex-1 min-h-0 overflow-y-auto"> | ||
| {renderContent()} | ||
| </div> | ||
| <PanelFooter | ||
| version={appVersion} | ||
| autoUpdateNextAt={autoUpdateNextAt} | ||
| updateStatus={updateStatus} | ||
| onUpdateInstall={triggerInstall} | ||
| <div ref={containerRef} className="flex flex-col items-center pt-1.5"> | ||
| <div className="tray-arrow" /> | ||
| <div | ||
| className="bg-card rounded-lg border shadow-lg overflow-hidden select-none w-full" | ||
| style={maxPanelHeightPx ? { maxHeight: `${maxPanelHeightPx}px` } : undefined} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When content reaches the max-height cap, Useful? React with 👍 / 👎.
cursor[bot] marked this conversation as resolved.
Outdated
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
|
||
| > | ||
| <div className="flex h-full min-h-0 flex-row"> | ||
| <SideNav | ||
| activeView={activeView} | ||
| onViewChange={setActiveView} | ||
| plugins={navPlugins} | ||
| /> | ||
| <div className="flex-1 flex flex-col px-3 pt-2 pb-1.5 min-w-0"> | ||
| <div className="flex-1 min-h-0 overflow-y-auto"> | ||
| {renderContent()} | ||
| </div> | ||
| <PanelFooter | ||
| version={appVersion} | ||
| autoUpdateNextAt={autoUpdateNextAt} | ||
| updateStatus={updateStatus} | ||
| onUpdateInstall={triggerInstall} | ||
| /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Low
src/App.tsx:492The new wrapper's
pt-1.5padding and.tray-arrowheight aren't accounted for inmaxPanelHeightPx. Consider subtracting the wrapper overhead from the inner card'smaxHeightso the footer remains visible when content is tall.