Skip to content

Conversation

@dpiparo
Copy link
Member

@dpiparo dpiparo commented Sep 28, 2017

Give the possibility to the user to get the column names from the TDataFrame nodes.

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@eguiraud
Copy link
Contributor

Cool!
I know this is a first draft, just two preliminary comments: maybe GetColumnNames would be more descriptive; we cannot return all of the custom column names, as some will not belong to the current "chain" of the graph. TInterface::fValidColumnNames would be the right list.

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Warnings:

  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Warnings:

  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Warnings:

  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Warnings:

  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable ‘base’ [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Warnings:

  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable 'base' [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable 'base' [-Wunused-variable]
  • include/ROOT/TDFInterface.hxx:1548:18: warning: unused variable 'base' [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

1 similar comment
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@dpiparo
Copy link
Member Author

dpiparo commented Sep 29, 2017

Comment addressed, RN updated, tests added. Ready to go if jenkins agrees.

@dpiparo dpiparo merged commit f0221e2 into root-project:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants