Skip to content

GetColumn method of the interface #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 5 commits into from
Sep 29, 2017
Merged

GetColumn method of the interface #1071

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af8fde0
[TDF] Add the GetColumnNames method to the TInterface
dpiparo Sep 28, 2017
977aa43
[TDF] Test the GetColumnNames method of TDF::TInterface
dpiparo Sep 29, 2017
c248a5f
Update Release notes
dpiparo Sep 29, 2017
ca17b77
Formatting
dpiparo Sep 29, 2017
1c56dbc
[TDF] Avoid that clang-format formats doxy for a method
dpiparo Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TDF] Test the GetColumnNames method of TDF::TInterface
  • Loading branch information
@dpiparo
dpiparo committed Sep 29, 2017
commit 977aa43f861ca0d92a26bbcaab0f9eb8fc81855d
37 changes: 37 additions & 0 deletions tree/treeplayer/test/dataframe/dataframe_interface.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
#include "ROOT/TDataFrame.hxx"
#include "ROOT/TTrivialDS.hxx"
#include "TMemFile.h"
#include "TTree.h"

#include "gtest/gtest.h"

using namespace ROOT::Experimental;
using namespace ROOT::Experimental::TDF;

TEST(TDataFrameInterface, CreateFromNullTDirectory)
{
Expand Down Expand Up @@ -89,3 +91,38 @@ TEST(TDataFrameInterface, CheckAliasesPerChain)
}
EXPECT_EQ(0, ret) << "No exception thrown when trying to alias a non-existing column.";
}

TEST(TDataFrameInterface, GetColumnNamesFromScratch)
{
TDataFrame f(1);
auto dummyGen = []() { return 1; };
auto names = f.Define("a", dummyGen).Define("b", dummyGen).Define("__TDF_Dummy", dummyGen).GetColumnNames();
EXPECT_STREQ("a", names[0].c_str());
EXPECT_STREQ("b", names[1].c_str());
EXPECT_EQ(2U, names.size());
}

TEST(TDataFrameInterface, GetColumnNamesFromTree)
{
TTree t("t","t");
int a,b;
t.Branch("a",&a);
t.Branch("b",&b);
TDataFrame tdf(t);
auto names = tdf.GetColumnNames();
EXPECT_STREQ("a", names[0].c_str());
EXPECT_STREQ("b", names[1].c_str());
EXPECT_EQ(2U, names.size());
}

TEST(TDataFrameInterface, GetColumnNamesFromSource)
{
std::unique_ptr<TDataSource> tds(new TTrivialDS(1));
TDataFrame tdf(std::move(tds));
auto names = tdf.Define("b", []() { return 1; }).GetColumnNames();
EXPECT_STREQ("b", names[0].c_str());
EXPECT_STREQ("col0", names[1].c_str());
EXPECT_EQ(2U, names.size());
}