Add support for Windows (Visual Studio) in the cmake infrastructure #1088

bellenot · 2017-10-02T08:00:00Z

Add missing includes (gdk/glib) for TGWin32 dictionary generation
Replace use of bindexplib by CMake's built-in WINDOWS_EXPORT_ALL_SYMBOLS property
Replace old nmake based build by the CMake based one for builtin_freetype and builtin_pcre
Add support for Visual Studio for LZ4
Fix compilation of builtin_afterimage
Add a few missing compilation flags
Filter out the multiproc sub-directory (not supported on Windows)

- Add missing includes (gdk/glib) for TGWin32 dictionary generation - Replace use of bindexplib by CMake's built-in WINDOWS_EXPORT_ALL_SYMBOLS property - Replace old nmake based build by the CMake based one for builtin_freetype and builtin_pcre - Add support for Visual Studio for LZ4 - Fix compilation of builtin_afterimage - Add a few missing compilation flags - Filter out the multiproc sub-directory

phsft-bot · 2017-10-02T08:00:20Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-10-02T08:01:38Z

Build failed on centos7/gcc49.
See console output.

phsft-bot · 2017-10-02T08:01:58Z

Build failed on slc6/gcc49.
See console output.

phsft-bot · 2017-10-02T08:02:06Z

Build failed on slc6/gcc62.
See console output.

amadio · 2017-10-02T08:27:52Z

CMakeLists.txt

    set(__allIncludes ${__allIncludes} -I${d})
  endif()
 endforeach()
+if(MSVC)


Maybe if (WIN32) makes more sense here in case one uses a different compiler on Windows?

I agree for this one (sometimes it's really compiler dependent)

amadio · 2017-10-02T09:49:16Z

cmake/modules/SearchInstalledSoftware.cmake

+    file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/include" NATIVE_INCLUDEDIR)
+    ExternalProject_Add(
+      LZ4
+      URL http://lcgpackages.web.cern.ch/lcgpackages/tarFiles/sources/lz4-${lz4_version}.tar.gz


Maybe it's worth to avoid duplication of URL and MD5 hash. How about

set(LZ4_URL ${lcgpackages}/lz4-${lz4_version}.tar.gz) set(LZ4_MD5 c9610c5ce97eb431dddddf0073d919b9)

and then use the variables in both branches? That way we only have one place to update if something changes.

Good point, thanks! Will do it

amadio · 2017-10-02T09:52:51Z

@phsft-bot build

Relaunching now that externals are fixed.

phsft-bot · 2017-10-02T09:53:08Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-10-02T10:03:41Z

Build failed on slc6/gcc49.
See console output.

phsft-bot · 2017-10-02T10:03:59Z

Build failed on slc6/gcc62.
See console output.

…d5 for LZ4 (thanks Guilherme for the feedback)

phsft-bot · 2017-10-02T11:53:14Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-10-02T12:44:12Z

Build failed on slc6/gcc62.
See console output.

Errors:

ERROR: Timeout after 10 minutes
ERROR: Error fetching remote repo 'origin'
stderr: error: RPC failed; result=18, HTTP code = 200
error: fetch-pack died of signal 15
ERROR: Error fetching remote repo 'origin'

phsft-bot · 2017-10-02T12:46:42Z

Build failed on slc6/gcc49.
See console output.

Errors:

ERROR: Timeout after 10 minutes
ERROR: Error fetching remote repo 'origin'
stderr: error: RPC failed; result=18, HTTP code = 200
ERROR: Error fetching remote repo 'origin'

bellenot · 2017-10-02T15:22:24Z

@phsft-bot build

phsft-bot · 2017-10-02T15:22:43Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-10-02T16:01:56Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.tree.stl.roottest_root_tree_stl_make

phsft-bot · 2017-10-02T17:15:45Z

Build failed on mac1012/native.
See console output.

Failing tests:

projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_WebRootls1

bellenot · 2017-10-03T07:03:50Z

@phsft-bot build

phsft-bot · 2017-10-03T07:04:06Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-10-03T08:14:58Z

Build failed on ubuntu14/native.
See console output.

Warnings:

include/ROOT/TDFInterface.hxx:859:50: warning: declaration of ‘nSlots’ shadows a global declaration [-Wshadow]
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/tree/treeplayer/test/dataframe/dataframe_callbacks.cxx:12:31: warning: shadowed declaration is here [-Wshadow]
include/ROOT/TDFInterface.hxx:829:50: warning: declaration of ‘nSlots’ shadows a global declaration [-Wshadow]
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/tree/treeplayer/test/dataframe/dataframe_callbacks.cxx:12:31: warning: shadowed declaration is here [-Wshadow]
include/ROOT/TDFInterface.hxx:1471:50: warning: declaration of ‘nSlots’ shadows a global declaration [-Wshadow]
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/tree/treeplayer/test/dataframe/dataframe_callbacks.cxx:12:31: warning: shadowed declaration is here [-Wshadow]
include/ROOT/TDFInterface.hxx:1489:58: warning: declaration of ‘nSlots’ shadows a global declaration [-Wshadow]
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/tree/treeplayer/test/dataframe/dataframe_callbacks.cxx:12:31: warning: shadowed declaration is here [-Wshadow]
include/ROOT/TDFInterface.hxx:1471:50: warning: declaration of ‘nSlots’ shadows a global declaration [-Wshadow]
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/tree/treeplayer/test/dataframe/dataframe_callbacks.cxx:12:31: warning: shadowed declaration is here [-Wshadow]

And 24 more

Failing tests:

projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_dataframe_callbacks

phsft-bot · 2017-10-03T08:38:02Z

Build failed on mac1012/native.
See console output.

Failing tests:

projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_dataframe_callbacks

amadio · 2017-10-03T11:59:15Z

@bellenot Is this ready to be merged? The tests failures are fixed on master now, and are not related to this PR.

bellenot · 2017-10-03T12:22:22Z

@amadio yes, from my side, it can be merged...

bellenot requested review from Axel-Naumann, amadio, pcanal and peremato October 2, 2017 08:00

amadio requested changes Oct 2, 2017

View reviewed changes

Use WIN32 instead of MSVC in cmake and avoid duplication of url and m…

66c97f4

…d5 for LZ4 (thanks Guilherme for the feedback)

amadio self-assigned this Oct 3, 2017

amadio merged commit 8a6dd99 into root-project:master Oct 3, 2017

bellenot deleted the add-visual-studio-support branch February 8, 2018 08:08

phsft-bot mentioned this pull request May 17, 2023

[TCling] C++-use string,vector instead of std. #11027

Draft

Add support for Windows (Visual Studio) in the cmake infrastructure #1088

Add support for Windows (Visual Studio) in the cmake infrastructure #1088

Uh oh!

Conversation

bellenot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

amadio Oct 2, 2017

Choose a reason for hiding this comment

Uh oh!

bellenot Oct 2, 2017

Choose a reason for hiding this comment

Uh oh!

amadio Oct 2, 2017

Choose a reason for hiding this comment

Uh oh!

bellenot Oct 2, 2017

Choose a reason for hiding this comment

Uh oh!

amadio commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Errors:

Uh oh!

phsft-bot commented Oct 2, 2017

Errors:

Uh oh!

bellenot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Uh oh!

phsft-bot commented Oct 2, 2017

Failing tests:

Uh oh!

phsft-bot commented Oct 2, 2017

Failing tests:

Uh oh!

bellenot commented Oct 3, 2017

Uh oh!

phsft-bot commented Oct 3, 2017

Uh oh!

phsft-bot commented Oct 3, 2017

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Oct 3, 2017

Failing tests:

Uh oh!

amadio commented Oct 3, 2017

Uh oh!

bellenot commented Oct 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants