[TCling] C++-use string,vector instead of std. #11027
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
Axel-Naumann
changed the title
Member
|
Note: this change obviously allows 'new' code to work better (allows use of user-defined |
|
Build failed on windows10/cxx14. Failing tests: |
Member
Author
|
Correct - and I wanted to start small ( |
Axel-Naumann
force-pushed
the
using-things-instead-of-using-namespace-std
branch
from
ca81ff4 to
d83ea7b
Compare
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
|
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
|
Build failed on mac12/noimt. Errors:
And 11 more |
|
Build failed on windows10/cxx14. Errors:
And 103 more |
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
|
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
|
Build failed on ROOT-debian10-i386/soversion. |
|
Build failed on mac12/noimt. Errors:
And 11 more |
|
Build failed on windows10/cxx14. Errors:
And 103 more |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. |
|
Build failed on mac11/cxx14. Errors:
And 11 more |
This prevents clashes e.g. of `std::data` ands `data` variables and alike.
Axel-Naumann
force-pushed
the
using-things-instead-of-using-namespace-std
branch
from
1596e16 to
fbd0bc6
Compare
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. |
|
Build failed on ROOT-debian10-i386/soversion. |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. |
|
Build failed on mac11/cxx14. Errors:
And 56 more Failing tests:
And 241 more |
This prevents TClass getting confused about normalized names in std:: which will likely be implementation details
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
And 57 more Failing tests:
And 256 more |
|
Build failed on mac11/cxx14. Errors:
And 56 more Failing tests:
And 263 more |
|
Starting build on |
|
Build failed on windows10/cxx14. |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
Failing tests:
And 97 more |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
And 47 more |
|
Build failed on mac11/cxx14. Errors:
Failing tests:
And 107 more |
|
Build failed on ROOT-debian10-i386/soversion. Failing tests:
And 51 more |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state:
std::std::where "needed", to the normalized name, to make identifiers "compilable" (in dictionary source).The last point requires to have an authoritative list of "things in the std namespace", to prepend
std::to them. This does not scale - any stdlib implementation might have any non-public identifier that might be needed also for public types, e.g. some libstdc++ havestd::thread::idas type alias tostd::__thread_id.Alternatively, this PR could implement a "if lookup fails, try again with prepending
std::". This is an issue for types such asfoo<bar, baz<boo,boz>>where either any type must be tested for std-ization separately or all possible permutations (std::foo<bar, baz<boo,boz>>,foo<std::bar, baz<boo,boz>>,std::foo<std::bar, baz<boo,boz>>...) must be tried.