Update llvm to release 5.0 #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM 5.0 introduces a field to describe possible allowed option values. This aids the auto completion machanisms.
The orc jit API evolved as follows: * Use better error handling via llvm::Error and llvm::Expected<> * Switch back to the single llvm::Module concept as opposed to sets. * Use more expressive ownership model: extensive use of smart ptrs.
If we cannot return an address we should assert and handle the diags.
We can only consume it with calling a special interface or calling ConsumeAnyToken.
This was probably due to non-proprely merged conflict.
Add an llvm_unreachable to handle potential errors.
Force using the old behavior and explain why it is not so good idea.
|
Starting build on |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on centos7/gcc49. Failing tests: |
|
Build failed on slc6/gcc49. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on mac1012/native. Warnings:
And 10 more Failing tests: |
Member
Author
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on centos7/gcc49. Failing tests: |
|
Build failed on slc6/gcc49. Failing tests: |
|
Build failed on mac1012/native. Warnings:
And 10 more Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
This was referenced Nov 1, 2017
Merged
|
Starting build on |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on centos7/gcc49. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on slc6/gcc49. Failing tests: |
|
Build failed on mac1012/native. Warnings:
And 10 more Failing tests: |
enirolf
pushed a commit
to enirolf/root
that referenced
this pull request
Apr 23, 2025
Add test for cv qualified vars sibling of root-project#16924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR roots our llvm vendor drop to the LLVM's 5.0 release. Updating llvm will enable C++17 support in ROOT. There are many advantages of doing that such as relying on a release which is very thoroughly tested.
After many years, this update removes practically all cling/ROOT-specific patches from llvm which means that technically we can link against vanilla llvm. Note that we still have (a reduced) set of patches in clang.
Note this comes with a few issues (thus the do-not-merge label):