[cxxmodules] Backport D39416 #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Teemperor
force-pushed
the
BackportD39416
branch
2 times, most recently
from
aa68abf to
258f800
Compare
See https://reviews.llvm.org/D39416 for more details. Original commit message: The MultiplexExternalSemaSource doesn't correctly overload the getModule function, causing the multiplexer to not forward this call as intended.
|
Starting build on |
1 similar comment
|
Starting build on |
Member
|
Depends on PR #1218 . |
ellert
added a commit
to ellert/root
that referenced
this pull request
Aug 27, 2025
Fixes test failures on 32 bit intel ix86. The following tests FAILED: 62 - pyunittests-bindings-pyroot-pythonizations-pyroot-pyz-rdataframe-makenumpy (Failed) python python_runtime_deps 1257 - tutorial-analysis-dataframe-df032_RDFFromNumpy-py (Failed) python_runtime_deps tutorial 1259/1470 Test root-project#1257: tutorial-analysis-dataframe-df032_RDFFromNumpy-py .............................................***Failed 1.14 sec Traceback (most recent call last): File ".../tutorials/analysis/dataframe/df032_RDFFromNumpy.py", line 23, in <module> df = ROOT.RDF.FromNumpy({'x': x, 'y': y}) File ".../redhat-linux-build/lib/ROOT/_facade.py", line 349, in MakeNumpyDataFrameCopy return _MakeNumpyDataFrame(np_dict) File ".../redhat-linux-build/lib/ROOT/_pythonization/_rdataframe.py", line 601, in _MakeNumpyDataFrame return ROOT.Internal.RDF.MakeRVecDataFrame(ROOT.__ROOT_Internal.MakePyDeleter(key), *args) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^ OverflowError: Python int too large to convert to C long
vepadulano
pushed a commit
that referenced
this pull request
Aug 28, 2025
Fixes test failures on 32 bit intel ix86. The following tests FAILED: 62 - pyunittests-bindings-pyroot-pythonizations-pyroot-pyz-rdataframe-makenumpy (Failed) python python_runtime_deps 1257 - tutorial-analysis-dataframe-df032_RDFFromNumpy-py (Failed) python_runtime_deps tutorial 1259/1470 Test #1257: tutorial-analysis-dataframe-df032_RDFFromNumpy-py .............................................***Failed 1.14 sec Traceback (most recent call last): File ".../tutorials/analysis/dataframe/df032_RDFFromNumpy.py", line 23, in <module> df = ROOT.RDF.FromNumpy({'x': x, 'y': y}) File ".../redhat-linux-build/lib/ROOT/_facade.py", line 349, in MakeNumpyDataFrameCopy return _MakeNumpyDataFrame(np_dict) File ".../redhat-linux-build/lib/ROOT/_pythonization/_rdataframe.py", line 601, in _MakeNumpyDataFrame return ROOT.Internal.RDF.MakeRVecDataFrame(ROOT.__ROOT_Internal.MakePyDeleter(key), *args) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^ OverflowError: Python int too large to convert to C long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://reviews.llvm.org/D39416 for more details. Original commit message:
The MultiplexExternalSemaSource doesn't correctly overload the getModule function,
causing the multiplexer to not forward this call as intended.