[cxxmodules] Also preload TMVA/TreePlayer #1355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Contributor
Author
|
@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/clang_gcc62. Errors:
|
Member
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
Teemperor
force-pushed
the
PreloadTMVATreePlayer
branch
from
e0c2fcf to
abbd36c
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
vgvassilev
reviewed
Nov 23, 2017
|
|
||
| if (!fromRootCling) { | ||
| neededCoreModuleNames.push_back("TreePlayer"); | ||
| neededCoreModuleNames.push_back("TMVA"); |
Member
There was a problem hiding this comment.
Could you load Graf for TPaveText? That's stumbling my PR #1356.
Teemperor
force-pushed
the
PreloadTMVATreePlayer
branch
from
abbd36c to
2a2600f
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 210 more |
ROOT can't autoparse classes inside namespaces with the rootmap system (as the loading callbacks don't correctly land where they are supposed to land with our injected namespaces). As this turns out to be a feature of some kind, let's preload TMVA/TreePlayer to fix all failing tests that are related to this feature/bug with modules enabled.
Teemperor
force-pushed
the
PreloadTMVATreePlayer
branch
from
2a2600f to
206dab6
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
Starting build on |
|
Build failed on slc6/gcc62. |
Teemperor
force-pushed
the
PreloadTMVATreePlayer
branch
from
445557b to
5f3a4e7
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 226 more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT can't autoparse classes inside namespaces with the rootmap
system (as the loading callbacks don't correctly land where
they are supposed to land with our injected namespaces). As this
turns out to be a feature of some kind, let's preload TMVA/TreePlayer
to fix all failing tests that are related to this feature/bug with
modules enabled.