[cxxmodules] Teach TCling::RegisterModule to work with real module fi… #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Member
Author
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
Member
|
Way to go, @vgvassilev ! (Crossing my fingers for roottest...) |
|
Build failed on slc6/gcc62. Errors:
And 7 more Warnings:
And 7 more Failing tests:
And 398 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
6aee1ec to
2b4fd2b
Compare
|
Starting build on |
Teemperor
reviewed
Nov 23, 2017
core/metacling/src/TCling.cxx
Outdated
| if (TheSema.getLangOpts().Modules) { | ||
| bool success = LoadModule(llvm::StringRef(modulename).substr(3), *fInterpreter); | ||
| (void)success; | ||
| assert(success && "Failed to load module!"); |
Contributor
There was a problem hiding this comment.
Maybe worth turning this into an error that prints the module name.
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
2b4fd2b to
836f351
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 10 more Warnings:
And 7 more Failing tests:
And 369 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
836f351 to
b9966b1
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 2 more Warnings:
And 7 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
b9966b1 to
4bbbebe
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
4bbbebe to
160ae73
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 98 more Warnings:
And 7 more Failing tests:
And 396 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
160ae73 to
ff9e727
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more Failing tests:
And 255 more |
|
Starting build on |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
49929ea to
97b2b41
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 8 more Warnings:
And 7 more Failing tests:
And 62 more |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
b5e8775 to
a0d83d1
Compare
|
Starting build on |
Contributor
|
Hi @vgvassilev I think you picked up a couple of commits while rebasing that shouldn't be in this PR? :) |
|
Build failed on slc6/gcc62. Errors:
Warnings:
|
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
a0d83d1 to
4946f4d
Compare
|
Starting build on |
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
4946f4d to
3e62f9d
Compare
|
Starting build on |
Member
Author
|
@bluehood, thanks for the hint. It looks like a GH issue. My branch looks okay. |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more Failing tests:
And 42 more |
Member
Author
|
@phsft-bot build with flags -Druntime_cxxmodules=Off -Dctest_test_exclude_none=off |
|
Starting build on |
…les. When we load a library, during its static intialization it calls TCling::RegisterModule to make ROOT's runtime aware of that load. Regular ROOT also will do some header parsing to add the minimal infrastructure in place for cling to be able to call into that library. C++ modules define away the need to parse. This patch intends to skip all parsing at this stage and fix recursive parsing issues for C++ modules.
vgvassilev
force-pushed
the
RegisterModuleLoadModule
branch
from
3e62f9d to
fdb2f41
Compare
|
Starting build on |
|
Build failed on mac1012/native. Failing tests: |
|
Build failed on ubuntu14/native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…les.
When we load a library, during its static intialization it calls
TCling::RegisterModule to make ROOT's runtime aware of that load. Regular
ROOT also will do some header parsing to add the minimal infrastructure
in place for cling to be able to call into that library.
C++ modules define away the need to parse. This patch intends to skip all
parsing at this stage and fix recursive parsing issues for C++ modules.