Skip to content

[testing][cxxmodules]Reuse def loc #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Teemperor wants to merge 5 commits into from
Closed

[testing][cxxmodules]Reuse def loc #1378

Teemperor wants to merge 5 commits into from

Conversation

@Teemperor
Copy link
Contributor

@Teemperor Teemperor commented Nov 27, 2017

No description provided.

@Teemperor Teemperor requested a review from pcanal as a code owner November 27, 2017 22:54
@phsft-bot
Copy link

phsft-bot commented Nov 27, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

1 similar comment
@phsft-bot
Copy link

phsft-bot commented Nov 27, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Nov 27, 2017

Build failed on centos7/gcc49.
See console output.

@phsft-bot
Copy link

phsft-bot commented Nov 28, 2017

Build failed on slc6/gcc49.
See console output.

@phsft-bot
Copy link

phsft-bot commented Nov 28, 2017

Build failed on mac1012/native.
See console output.

@phsft-bot
Copy link

phsft-bot commented Nov 28, 2017

Build failed on slc6/gcc62.
See console output.

@phsft-bot
Copy link

phsft-bot commented Nov 28, 2017

Build failed on ubuntu14/native.
See console output.

@phsft-bot
Copy link

phsft-bot commented Nov 28, 2017

Build failed on ubuntu14/native.
See console output.

@Teemperor Teemperor closed this Nov 28, 2017
vgvassilev
vgvassilev reviewed Nov 28, 2017
View reviewed changes
core/metacling/src/TCling.cxx

assert(interp.getMacro("gROOT") && "Couldn't load gROOT macro?");
interp.declare("#include <cassert>\n");
interp.declare("#ifdef I\n #undef I\n #endif\n");
Copy link
Member

@vgvassilev vgvassilev Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move that in the else part of case LIBM? Probably we can use a PP API to undefine I and avoid recursive parsing.

@Teemperor Teemperor mentioned this pull request Nov 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgvassilev vgvassilev vgvassilev left review comments

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@vgvassilev vgvassilev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Teemperor @phsft-bot @vgvassilev