[cxxmodules] Export macros from modules #1381

Teemperor · 2017-11-28T08:52:43Z

This PR fixes the issue that we don't export macros from the loaded modules. See the specific commits for more.

phsft-bot · 2017-11-28T08:52:59Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Teemperor · 2017-11-28T08:53:28Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-11-28T08:53:38Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

vgvassilev

LGTM!

vgvassilev · 2017-11-28T10:15:30Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-11-28T10:15:46Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

vgvassilev · 2017-11-28T10:25:46Z

@phsft-bot build just on slc6/gcc52 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-11-28T10:25:58Z

Didn't recognize slc6/gcc52 aborting build.

vgvassilev · 2017-11-28T10:28:19Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-11-28T10:28:30Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

Teemperor · 2017-11-28T10:45:22Z

core/metacling/src/TCling.cxx

+   // Let's follow the GCC recommendation and undefine `I` in case any of the
+   // core modules have defined it:
+   // https://www.gnu.org/software/libc/manual/html_node/Complex-Numbers.html
+   interp.declare("#ifdef I\n #undef I\n #endif\n");


@vgvassilev I reply here to your comment on the closed PR. I don't think we call recursively LoadCoreModule or recursively make TCling instances? And if we do, then we already made a good portion of declares before this code for all the other TCling things, so we would anyway be in deep trouble.

I think we ought to reduce all declares in TCling and that seems to be an easy-to-reduce one.

In clang there are two records of what modules are visible: One VisibleModuleSet is in the preprocessor, one is in the sema. In the current code we only make every core module visible in sema, but no in the preprocessor. This causes that we can load decls from the core modules with that, but we can't load macros from them as they are still invisible in the preprocessor. This patch just also makes the module visible in the preprocessor.

phsft-bot · 2017-11-28T11:06:22Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

In commit 1847320 we remove the code that undefs I which breaks some tests since we now again export macros from the STL module.

phsft-bot · 2017-11-28T12:50:44Z

Build failed on slc6/gcc62.
See console output.

Errors:

297/1649 Test Fix GCC 6 compilation (tested on ArchLinux) #188: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.02 sec
545/1649 Test [cxxmodules] Don't use the VFS overlay for the dictionaries #447: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.87 sec
573/1649 Test [CLANG] Increase default value for -ftemplate-depth to 1024 #478: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 2.91 sec
689/1649 Test Add 1-vs-rest and 1-vs-1 performance measures to TMVA multiclass output #597: tutorial-roostats-Zbi_Zgamma ......................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.02 sec
701/1649 Test Supress R warnings in ROOT build #609: tutorial-roostats-rs_numbercountingutils ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.03 sec
737/1649 Test Several fixes and improvements for the vectorized implementations #649: tutorial-tmva-keras-LaunchClasGUI .................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.50 sec
739/1649 Test Fixing an O(N^2) scaling problem caused by TTree::Draw() #650: tutorial-tmva-keras-LaunchMultiGUI ................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.49 sec
740/1649 Test Fix buffer overflow. #651: tutorial-tmva-keras-LaunchRegGUI ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.59 sec
779/1649 Test Always generate a ROOT modulemap and install it. #700: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.33 sec

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:

And 7 more

Failing tests:

And 53 more

Teemperor · 2017-11-28T13:18:37Z

@phsft-bot build with flags -Druntime_cxxmodules=Off -Dctest_test_exclude_none=off

phsft-bot · 2017-11-28T13:18:52Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=Off -Dctest_test_exclude_none=off
How to customize builds

phsft-bot · 2017-11-28T15:19:18Z

Build failed on mac1012/native.
See console output.

Failing tests:

projectroot.roottest.root.dataframe.roottest_root_dataframe_reports

Teemperor assigned vgvassilev Nov 28, 2017

Teemperor requested a review from vgvassilev November 28, 2017 08:52

Teemperor requested a review from pcanal as a code owner November 28, 2017 08:52

Teemperor changed the title ~~Export macros from modules~~ [cxxmodules] Export macros from modules Nov 28, 2017

vgvassilev approved these changes Nov 28, 2017

View reviewed changes

Teemperor commented Nov 28, 2017

View reviewed changes

Teemperor force-pushed the ExportMacrosFromModules branch from 52021b0 to dfe40dd Compare November 28, 2017 11:06

[cxxmodules] Undef I again (partly reverts 1847320)

dfe40dd

In commit 1847320 we remove the code that undefs I which breaks some tests since we now again export macros from the STL module.

vgvassilev merged commit 5d451b1 into root-project:master Nov 28, 2017

[cxxmodules] Export macros from modules #1381

[cxxmodules] Export macros from modules #1381

Uh oh!

Conversation

Teemperor commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

Teemperor commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

vgvassilev left a comment

Choose a reason for hiding this comment

Uh oh!

vgvassilev commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

vgvassilev commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

vgvassilev commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

Teemperor Nov 28, 2017

Choose a reason for hiding this comment

Uh oh!

vgvassilev Nov 28, 2017

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Errors:

Warnings:

Failing tests:

Uh oh!

Teemperor commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Uh oh!

phsft-bot commented Nov 28, 2017

Failing tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants