[cxxmodules] Also preload TMVA/TreePlayer/Graf #1396

Teemperor · 2017-11-29T10:37:23Z

ROOT can't autoparse classes inside namespaces with the rootmap
system (as the loading callbacks don't correctly land where
they are supposed to land with our injected namespaces). As this
turns out to be a feature of some kind, let's preload
TMVA/TreePlayer/Graf to fix all failing tests that are related
to this feature/bug with modules enabled.

This commit can be dropped if we solve on of those problems:

figure out how to fix this bug in the rootmap-based loading
without regressin in performance.
replace the rootmap system with something else like attaching
all C++ modules on startup.

Note that we already do something like this in normal ROOT by
including these packages into the PCH which also makes those
decls available in the normal clang lookup.

This PR depends on #1394

phsft-bot · 2017-11-29T10:37:37Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-11-29T10:42:18Z

Build failed on centos7/gcc49.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1130:11: error: ‘CI’ was not declared in this scope
../root/core/metacling/src/TCling.cxx:1379:60: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

phsft-bot · 2017-11-29T10:43:12Z

Build failed on mac1012/native.
See console output.

Errors:

/Volumes/MacintoshHD/build/jenkins/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:1130:11: error: use of undeclared identifier 'CI'
/Volumes/MacintoshHD/build/jenkins/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:1379:4: error: no matching function for call to 'LoadModules'

phsft-bot · 2017-11-29T10:43:15Z

Build failed on slc6/gcc62.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1130:11: error: ‘CI’ was not declared in this scope
../root/core/metacling/src/TCling.cxx:1379:48: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

phsft-bot · 2017-11-29T10:44:54Z

Build failed on slc6/gcc62.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1379:48: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

phsft-bot · 2017-11-29T10:44:59Z

Build failed on slc6/gcc49.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1130:11: error: ‘CI’ was not declared in this scope
../root/core/metacling/src/TCling.cxx:1379:60: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

phsft-bot · 2017-11-29T10:53:54Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Teemperor · 2017-11-29T10:54:26Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-11-29T10:55:07Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-11-29T11:00:50Z

Build failed on slc6/gcc62.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1377:48: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:

phsft-bot · 2017-11-29T13:42:25Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-11-29T13:48:28Z

Build failed on slc6/gcc62.
See console output.

Errors:

Error in <TCling::LoadModule>: Module TMVA not found!
Error: Error loading the default header files.

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:

And 7 more

phsft-bot · 2017-11-30T10:13:16Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-11-30T10:17:40Z

Build failed on slc6/gcc62.
See console output.

Errors:

../root/core/metacling/src/TCling.cxx:1377:48: error: invalid initialization of reference of type ‘cling::Interpreter&’ from expression of type ‘cling::Interpreter*’

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:

phsft-bot · 2017-11-30T13:50:48Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-11-30T14:49:24Z

Build failed on slc6/gcc62.
See console output.

Errors:

Error: *** Datamember TWebFile::fFullCache: no size indication!
Error: *** Datamember TWebFile::fFullCache: pointer to fundamental type (need manual intervention)
Error: *** Datamember TKeyXML::fKeyNode: no size indication!
Error: *** Datamember TKeyXML::fKeyNode: pointer to fundamental type (need manual intervention)
Error: *** Datamember TXMLFile::fDoc: no size indication!
Error: *** Datamember TXMLFile::fDoc: pointer to fundamental type (need manual intervention)
Error: *** Datamember TXMLFile::fStreamerInfoNode: no size indication!
Error: *** Datamember TXMLFile::fStreamerInfoNode: pointer to fundamental type (need manual intervention)

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:

And 7 more

phsft-bot · 2017-11-30T15:19:36Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-11-30T17:04:38Z

Build failed on slc6/gcc62.
See console output.

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:

And 7 more

NFC beside fixing the nullptr deref's in the previous LoadCoreModules implementation.

ROOT can't autoparse classes inside namespaces with the rootmap system (as the loading callbacks don't correctly land where they are supposed to land with our injected namespaces). As this turns out to be a feature of some kind, let's preload TMVA/TreePlayer/Graf to fix all failing tests that are related to this feature/bug with modules enabled. This commit can be dropped if we solve on of those problems: 1. figure out how to fix this bug in the rootmap-based loading without regressin in performance. 2. replace the rootmap system with something else like attaching all C++ modules on startup. Note that we already do something like this in normal ROOT by including these packages into the PCH which also makes those decls available in the normal clang lookup.

phsft-bot · 2017-12-19T08:44:13Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-12-19T09:31:05Z

Build failed on windows10/vc15.
See console output.

Errors:

ERROR: Error fetching remote repo 'origin'
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
ERROR: Error fetching remote repo 'origin'

phsft-bot · 2017-12-19T09:42:03Z

Build failed on slc6/gcc62.
See console output.

Errors:

ERROR: Timeout after 10 minutes
ERROR: Error fetching remote repo 'origin'
stderr: error: RPC failed; result=18, HTTP code = 200
ERROR: Error fetching remote repo 'origin'

phsft-bot · 2017-12-19T09:55:45Z

Build failed on ubuntu14/native.
See console output.

Errors:

ERROR: Error fetching remote repo 'origin'
stderr: error: RPC failed; result=18, HTTP code = 200
ERROR: Error fetching remote repo 'origin'

etejedor · 2018-02-20T13:49:11Z

Still depending on #1394

vgvassilev · 2018-03-03T16:57:34Z

Rebased in PR #1697.

Teemperor assigned vgvassilev Nov 29, 2017

Teemperor requested a review from vgvassilev November 29, 2017 10:37

Teemperor requested review from amadio and pcanal as code owners November 29, 2017 10:37

Teemperor mentioned this pull request Nov 29, 2017

Refactor load module #1392

Closed

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from ae109af to 7588a8a Compare November 29, 2017 10:53

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from 7588a8a to 0911233 Compare November 29, 2017 13:42

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from 0911233 to a7e0a6d Compare November 30, 2017 10:13

Teemperor added the do not merge label Nov 30, 2017

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from a7e0a6d to b375f37 Compare November 30, 2017 13:50

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from b375f37 to 3e75e26 Compare November 30, 2017 15:19

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from 3e75e26 to 0761be8 Compare November 30, 2017 19:36

vgvassilev and others added 21 commits December 3, 2017 22:39

[cxxmodules] Refactor LoadCoreModules.

6f4dfae

NFC beside fixing the nullptr deref's in the previous LoadCoreModules implementation.

[cxxmodules] Add flag if module has C++ module alongside it

08043ab

Fixed Vc abi check warning

fddd8e9

Add LD_LIBRARY_PATH to module path (broken commit?)

3f508e1

Also preload Gpad/RooStats

91cb046

Also load GenVector

57c235d

Another attempt at loading from library path

a0963eb

Also preload Hist

a1c8a35

Also preload Net

d72805b

Fixed library loading

cae72d1

Re-enable header parsing on demand

2e3d606

Also preload TreeViewer

67003b0

Also add cwd to prebuilt module path

0788356

also preload math

59819b1

Also preload TMVAGui

5b04cee

Also preload RooFit

034558d

Also preload RGL

dd365a4

Also preload EG

2331cb3

Math -> MathCore

02e971a

Use sparse vector in LoadedSLocEntryTable

c8311df

Teemperor force-pushed the PreloadTMVATreePlayerGraf branch from 95c31ae to c8311df Compare December 19, 2017 08:39

vgvassilev mentioned this pull request Mar 3, 2018

[cxxmodules] Preload more modules #1697

Closed

vgvassilev closed this Mar 3, 2018

[cxxmodules] Also preload TMVA/TreePlayer/Graf #1396

[cxxmodules] Also preload TMVA/TreePlayer/Graf #1396

Uh oh!

Conversation

Teemperor commented Nov 29, 2017

Uh oh!

phsft-bot commented Nov 29, 2017

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Uh oh!

phsft-bot commented Nov 29, 2017

Uh oh!

Teemperor commented Nov 29, 2017

Uh oh!

phsft-bot commented Nov 29, 2017

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Warnings:

Uh oh!

phsft-bot commented Nov 29, 2017

Uh oh!

phsft-bot commented Nov 29, 2017

Errors:

Warnings:

Uh oh!

phsft-bot commented Nov 30, 2017

Uh oh!

phsft-bot commented Nov 30, 2017

Errors:

Warnings:

Uh oh!

phsft-bot commented Nov 30, 2017

Uh oh!

phsft-bot commented Nov 30, 2017

Errors:

Warnings:

Uh oh!

phsft-bot commented Nov 30, 2017

Uh oh!

phsft-bot commented Nov 30, 2017

Warnings:

Uh oh!

phsft-bot commented Dec 19, 2017

Uh oh!

phsft-bot commented Dec 19, 2017

Errors:

Uh oh!

phsft-bot commented Dec 19, 2017

Errors:

Uh oh!

phsft-bot commented Dec 19, 2017

Errors:

Uh oh!

etejedor commented Feb 20, 2018

Uh oh!

vgvassilev commented Mar 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants