Refactor load module #1392
Closed
Refactor load module #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROOT can't autoparse classes inside namespaces with the rootmap system (as the loading callbacks don't correctly land where they are supposed to land with our injected namespaces). As this turns out to be a feature of some kind, let's preload TMVA/TreePlayer to fix all failing tests that are related to this feature/bug with modules enabled.
Rootcling's stage2 mode calls gDriverConfig->fTCling__GetInterpreter() to get the TCling's instance of the cling interpreter. This in turn might need to initialize TCling. Our modules setup preloads a modulemap but not the overlays preventing system modules such as libc and stl to be loaded. This criples rootcling and whenever it #includes a header file we get an error that we included a module from ROOT which depends on modules stl but it is not accessible through the module map.
|
Starting build on |
|
Build failed on centos7/gcc49. |
|
Build failed on ubuntu14/native. |
Teemperor
approved these changes
Nov 29, 2017
|
Build failed on mac1012/native. |
|
Build failed on slc6/gcc49. |
|
Build failed on slc6/gcc62. |
|
Build failed on windows10/vc15. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.