[cxxmodules] Don't generate C++ modules for clingutil STL dicts. #1457

Teemperor · 2017-12-12T15:05:00Z

These C++ modules serve no purpose as we

already have an STL dict.
they contain just interpreter clutter therefore.
care only about the generated IO information.

Let's disable them to get rid of all the build warning
when rootcling can't find the specific STL header that doesn't
exist inside ROOT:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  list
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  set

phsft-bot · 2017-12-12T15:05:11Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

These C++ modules serve no purpose as we 1. already have an STL dict. 2. they contain just interpreter clutter therefore. 3. care only about the generated IO information. Let's disable them to get rid of all the build warning when rootcling can't find the specific STL header that doesn't exist inside ROOT: ``` Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict: list Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict: set ```

vgvassilev

LGTM!

vgvassilev · 2017-12-13T09:16:51Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-13T09:20:36Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-13T10:10:50Z

Build failed on slc6/clang_gcc62.
See console output.

vgvassilev · 2017-12-13T10:12:37Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-13T10:12:44Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-13T10:20:26Z

Build failed on slc6/clang_gcc62.
See console output.

Teemperor · 2017-12-13T16:05:39Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-13T16:05:52Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-13T16:13:02Z

Build failed on slc6/clang_gcc62.
See console output.

Teemperor · 2017-12-14T07:37:09Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-14T07:41:36Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-14T07:49:33Z

Build failed on slc6/clang_gcc62.
See console output.

Teemperor · 2017-12-14T08:16:30Z

@phsft-bot build just on centos7/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-14T08:16:37Z

Starting build on centos7/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-14T08:16:40Z

Build failed on centos7/gcc62.
See console output.

Teemperor · 2017-12-14T08:25:05Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-14T08:25:12Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

Teemperor · 2017-12-14T12:13:04Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off

phsft-bot · 2017-12-14T12:13:10Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off
How to customize builds

Teemperor · 2017-12-14T12:17:07Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off

phsft-bot · 2017-12-14T12:17:13Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off
How to customize builds

phsft-bot · 2017-12-14T13:27:29Z

Build failed on slc6/gcc62.
See console output.

Errors:

288/1523 Test Update PR of Oliver #182: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.63 sec
538/1523 Test Replaced <math.h> with <cmath> to fix clang compilation. #440: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 3.03 sec
563/1523 Test Make TSeq iterator standard-compliant #471: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 6.86 sec
611/1523 Test Coverity fixes 82576, 82575, 68746, 68745, 68856, 61279, 61577 #526: tutorial-tmva-keras-LaunchClasGUI .................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.02 sec
612/1523 Test Print a warning when rootcling can't find the ROOT modulemap. #527: tutorial-tmva-keras-LaunchMultiGUI ................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.63 sec
614/1523 Test Be more specific on what is a header file to be moved and installed #528: tutorial-tmva-keras-LaunchRegGUI ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.92 sec
656/1523 Test Provide actions for text-based streamers #578: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.93 sec

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Thread:

Failing tests:

And 24 more

Teemperor assigned vgvassilev Dec 12, 2017

Teemperor requested a review from vgvassilev December 12, 2017 15:05

Teemperor requested a review from amadio as a code owner December 12, 2017 15:05

vgvassilev approved these changes Dec 12, 2017

View reviewed changes

vgvassilev merged commit 8759b1a into root-project:master Dec 14, 2017

Teemperor deleted the NoStlDictModules branch December 19, 2017 08:39

[cxxmodules] Don't generate C++ modules for clingutil STL dicts. #1457

[cxxmodules] Don't generate C++ modules for clingutil STL dicts. #1457

Uh oh!

Conversation

Teemperor commented Dec 12, 2017

Uh oh!

phsft-bot commented Dec 12, 2017

Uh oh!

vgvassilev left a comment

Choose a reason for hiding this comment

Uh oh!

vgvassilev commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

vgvassilev commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

Teemperor commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

Teemperor commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

Teemperor commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

Teemperor commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

Teemperor commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

Teemperor commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Uh oh!

phsft-bot commented Dec 14, 2017

Errors:

Warnings:

Failing tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants