Replaced <math.h> with <cmath> to fix clang compilation. #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the math functions in the std namespace, so math.h was wrong here.
|
Can one of the admins verify this patch? |
Member
|
@phsft-bot build! |
gganis
pushed a commit
to gganis/root
that referenced
this pull request
Apr 3, 2017
…t#440) We use the math functions in the std namespace, so math.h was wrong here.
This was referenced Dec 14, 2017
vgvassilev
pushed a commit
to vgvassilev/root
that referenced
this pull request
Nov 14, 2022
LLVM component must be registered as LLVM_LINK_COMPONENTS to be compatible with LLVM Dylib. Otherwise they are loaded twice in the final binary, once through LLVM Dylmib and once through individual component, and this results in some options being registered twice. Fix root-project#440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the math functions in the std namespace, so math.h was wrong here.