[cxxmodules] Remove TVersionCheck.h from Core C++ module blacklist

[Teemperor]

This header is directly included by TObject.h and directly including
it from some other header doesn't seem to be supported. As C++ modules
with submodule visibility simulate directl including each module header,
we seem to get some errors according to the comments in this header.

This patch removes it from the argument list of the
ROOT_GENERATE_DICTIONARY call which prevents it from getting directly
included in the Core C++ module. We can also remove it from the header
blacklist after this change.

The normal dictionary won't be affected by this. This header is anyway
not supposed to contain TVersionCheck.h but only TObject.h which will
still provide it in the right way.

[phsft-bot]

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

[Axel-Naumann]

directly including it from some other header doesn't seem to be supported

That's to the best of my knowledge incorrect.

[Teemperor]

@Axel-Naumann alright, then we have to see why the documentation seems to say that.

@vgvassilev Do you remember why we needed this? Is this still up to date?
https://github.com/root-project/root/blob/master/core/base/inc/TVersionCheck.h#L26

[vgvassilev]

@Teemperor, that line may be obsolete. IIRC that was from the days when we were running without -fmodules-local-submodule-visibility.

[phsft-bot]

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

[Teemperor]

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on slc6/clang_gcc62.
See console output.

[Teemperor]

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=Off -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on slc6/clang_gcc62.
See console output.

[Teemperor]

@phsft-bot build just on centos7/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on centos7/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on centos7/gcc62.
See console output.

[Teemperor]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[Teemperor]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off
How to customize builds

[Teemperor]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -Droofit=Off
How to customize builds

[phsft-bot]

Build failed on slc6/gcc62.
See console output.

Errors:

• 290/1523 Test Update PR of Oliver  #182: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.71 sec
• 538/1523 Test Replaced <math.h> with <cmath> to fix clang compilation. #440: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.94 sec
• 564/1523 Test Make TSeq iterator standard-compliant #471: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 3.78 sec
• 614/1523 Test Coverity fixes 82576, 82575, 68746, 68745, 68856, 61279, 61577 #526: tutorial-tmva-keras-LaunchClasGUI .................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.71 sec
• 615/1523 Test Print a warning when rootcling can't find the ROOT modulemap. #527: tutorial-tmva-keras-LaunchMultiGUI ................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.42 sec
• 616/1523 Test Be more specific on what is a header file to be moved and installed #528: tutorial-tmva-keras-LaunchRegGUI ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 4.99 sec
• 657/1523 Test Provide actions for text-based streamers #578: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.78 sec

Warnings:

• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_mapDict:
• Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:

And 7 more

Failing tests:

• projectroot.runtutorials.tutorial_dataframe_tdf013_InspectAnalysis
• projectroot.runtutorials.tutorial_math_quasirandom
• projectroot.runtutorials.tutorial_multicore_mtbb201_parallelHistoFill
• projectroot.runtutorials.tutorial_tmva_keras_LaunchClasGUI
• projectroot.runtutorials.tutorial_tmva_keras_LaunchMultiGUI
• projectroot.runtutorials.tutorial_tmva_keras_LaunchRegGUI
• projectroot.runtutorials.tutorial_dataframe_tdf002_dataModel_py
• projectroot.roottest.cling.array.roottest_cling_array_runarray1
• projectroot.roottest.cling.reflex.roottest_cling_reflex_make
• projectroot.roottest.root.aclic.misc.roottest_root_aclic_misc_assertROOT7027

And 23 more

[vgvassilev]

LGTM! I will open another PR removing the restriction I added some time ago.