TRatioPlot: Fixes to warnings and implementation of suggestions #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class TFileMergeInfo; | ||
|
|
||
| class TRatioPlot : public TPad { | ||
| class TRatioPlot : public TObject { |
Member
There was a problem hiding this comment.
If you inherit from TObject (and you should) then we need to #include TObject.h. If you source file starts with #include "TRatioPlot.h" then it should have told you - which is why that should be the first #include :-)
| /// ~~~ | ||
|
|
||
| TAxis* TRatioPlot::GetLowerRefYaxis() | ||
| TAxis* TRatioPlot::GetLowerRefYaxis() const |
Member
There was a problem hiding this comment.
These trivial one-liners could be inlined.
Contributor
Author
There was a problem hiding this comment.
@karies But can I write doxygen comments if they're inline? That's why I put them out-of-line
Member
There was a problem hiding this comment.
Yes, you can write doxygen also for inline funcs.
Contributor
Author
There was a problem hiding this comment.
Ah ok. I'll inline them then.
Member
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@couet
/cc @karies