Skip to content

TRatioPlot: Fixes to warnings and implementation of suggestions #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FonsRademakers merged 8 commits into from
Aug 31, 2016
Merged

TRatioPlot: Fixes to warnings and implementation of suggestions #228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59eda8d
do not inherit from TPad anymore. Remove constructor arguments
paulgessinger Aug 31, 2016
d6a4d35
remove virtual where probably not required and …
paulgessinger Aug 31, 2016
77d69cf
remove draw opts from constructors and add setters
paulgessinger Aug 31, 2016
38c5182
implement changes to remove warnings when using gcc
paulgessinger Aug 31, 2016
9873d74
make BuildLowerPlot really protected and non virtual
paulgessinger Aug 31, 2016
59248b4
remove overloaded TFitResult* setter
paulgessinger Aug 31, 2016
a5ea3e8
clean up #includes and update doc comments
paulgessinger Aug 31, 2016
6b2afa2
make all getters const
paulgessinger Aug 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove overloaded TFitResult* setter
  • Loading branch information
@paulgessinger
paulgessinger committed Aug 31, 2016
commit 59248b4a57c3c89bec279b6a16a6a3604d1f6b4b
1 change: 0 additions & 1 deletion graf2d/gpad/inc/TRatioPlot.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ class TRatioPlot : public TObject {

// Setters
void SetFitResult(TFitResultPtr fitres);
void SetFitResult(TFitResult *fitres);

// Setters for margins
void SetUpTopMargin(Float_t margin);
Expand Down
12 changes: 0 additions & 12 deletions graf2d/gpad/src/TRatioPlot.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,18 +1739,6 @@ void TRatioPlot::SetFitResult(TFitResultPtr fitres)
fFitResult = fitres.Get();
}

////////////////////////////////////////////////////////////////////////////////
/// Explicitly specify the fit result that is to be used for fit residual calculation.
/// If it is not provided, the last fit registered in the global fitter is used.
/// The fit result can also be specified in the constructor.
///
/// \param fitres The fit result coming from the fit function call

void TRatioPlot::SetFitResult(TFitResult* fitres)
{
fFitResult = fitres;
}

////////////////////////////////////////////////////////////////////////////////
/// Internal method to import TAxis attributes to a TGaxis. Copied from
/// `TGaxis::ImportAxisAttributes`
Expand Down