Revert "Revert "[cxxmodules] Don't generate rootmap files with cxxmod… #2380

yamaguchi1024 · 2018-07-27T11:56:40Z

…ules""

This reverts commit f409295.

IIRC this destoryed ACLiC. Let's fix this and remove rootmap files.

phsft-bot · 2018-07-27T11:56:49Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

yamaguchi1024 · 2018-07-27T11:57:24Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-07-27T11:57:45Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

yamaguchi1024 · 2018-07-27T13:29:58Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-07-27T13:41:50Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-07-28T10:59:19Z

Build failed on slc6/gcc62.
See console output.

Errors:

629/1573 Test Revised fix for ROOT-8452 #550: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.19 sec
630/1573 Test Removed redundant -fmodule-map-file= compilation flag. #551: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.10 sec
818/1573 Test Fix Windows exception handling for newer LLVM interfaces. Block it’s … #732: tutorial-tree-jets ................................................................................***Failed Error regular expression found in output. Regex=[: error:] 56.99 sec

Failing tests:

And 136 more

phsft-bot · 2018-07-31T12:14:58Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-07-31T13:46:03Z

Build failed on slc6/gcc62.
See console output.

yamaguchi1024 · 2018-07-31T15:24:45Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-07-31T15:25:00Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-07-31T19:00:55Z

Build failed on slc6/gcc62.
See console output.

Errors:

630/1573 Test Revised fix for ROOT-8452 #550: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.28 sec
631/1573 Test Removed redundant -fmodule-map-file= compilation flag. #551: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.41 sec

Failing tests:

And 243 more

phsft-bot · 2018-07-31T23:23:38Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-08-01T03:51:28Z

Build failed on slc6/gcc62.
See console output.

Errors:

629/1573 Test Revised fix for ROOT-8452 #550: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.25 sec
630/1573 Test Removed redundant -fmodule-map-file= compilation flag. #551: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.97 sec

Failing tests:

And 267 more

phsft-bot · 2018-08-01T06:56:55Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-08-01T11:18:51Z

Build failed on slc6/gcc62.
See console output.

Errors:

630/1573 Test Revised fix for ROOT-8452 #550: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.09 sec
631/1573 Test Removed redundant -fmodule-map-file= compilation flag. #551: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.12 sec

Failing tests:

And 89 more

phsft-bot · 2018-08-01T12:52:37Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-08-01T17:10:15Z

Build failed on slc6/gcc62.
See console output.

Errors:

629/1573 Test Revised fix for ROOT-8452 #550: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.14 sec
631/1573 Test Removed redundant -fmodule-map-file= compilation flag. #551: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.08 sec

Failing tests:

And 73 more

phsft-bot · 2018-08-02T13:22:27Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-08-02T13:22:52Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2018-08-03T15:28:16Z

Starting build on slc6/gcc62 with flags -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-08-03T19:56:08Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 100 more

phsft-bot · 2018-08-21T08:22:08Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

…ules"" This reverts commit f409295. IIRC this destoryed ACLiC. Let's fix this and remove rootmap files.

We were excluding these modules because it had conflict with local variables such as PI.

phsft-bot · 2018-08-21T13:41:01Z

Build failed on slc6/gcc62.
See console output.

Errors:

332/1642 Test GPU and multi-core accelerated neural networks in TMVA. #231: tutorial-benchmarks ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 14.93 sec
474/1642 Test Allow both absolute and relative python install paths #382: tutorial-graphics-tornado .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.20 sec
514/1642 Test [TDF] Split TDataFrame.hxx into multiple files #423: tutorial-hist-ContourList .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.26 sec
730/1642 Test Increased tolerance #652: tutorial-roostats-HybridInstructional .............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.76 sec
732/1642 Test Fix warnings on no-imt builds #654: tutorial-roostats-HybridStandardForm ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.81 sec

Failing tests:

And 207 more

vgvassilev · 2018-11-25T20:16:44Z

@yamaguchi1024 I think version of this already landed. I am closing this now but feel free to reopen if needed.

yamaguchi1024 added do not merge labels Jul 27, 2018

yamaguchi1024 requested a review from vgvassilev July 27, 2018 11:56

yamaguchi1024 requested a review from pcanal as a code owner July 27, 2018 11:56

yamaguchi1024 force-pushed the rootmap branch from 43c2080 to b7768a8 Compare July 31, 2018 12:14

yamaguchi1024 force-pushed the rootmap branch from b7768a8 to 83702a5 Compare July 31, 2018 23:23

yamaguchi1024 force-pushed the rootmap branch from 83702a5 to 3ff5160 Compare August 1, 2018 06:56

yamaguchi1024 force-pushed the rootmap branch from 3ff5160 to 5142fc3 Compare August 1, 2018 08:59

yamaguchi1024 force-pushed the rootmap branch from 5142fc3 to 92a862a Compare August 1, 2018 12:52

amadio assigned vgvassilev Aug 2, 2018

yamaguchi1024 force-pushed the rootmap branch from 66ecf12 to 9b70743 Compare August 3, 2018 15:28

yamaguchi1024 force-pushed the rootmap branch from 9b70743 to 6261b8c Compare August 21, 2018 08:21

yamaguchi1024 added 2 commits August 21, 2018 10:24

Revert "Revert "[cxxmodules] Don't generate rootmap files with cxxmod…

c65f373

…ules"" This reverts commit f409295. IIRC this destoryed ACLiC. Let's fix this and remove rootmap files.

[cxxmodules] Do not exclude R related module from preloading

6261b8c

We were excluding these modules because it had conflict with local variables such as PI.

yamaguchi1024 mentioned this pull request Aug 28, 2018

Cxx modules remove root maps #2534

Closed

yamaguchi1024 mentioned this pull request Sep 21, 2018

[cxxmodule] Don't declare fwd decls from rootmaps with modules #2592

Merged

vgvassilev closed this Nov 25, 2018

yamaguchi1024 deleted the rootmap branch February 20, 2019 17:23

Revert "Revert "[cxxmodules] Don't generate rootmap files with cxxmod… #2380

Revert "Revert "[cxxmodules] Don't generate rootmap files with cxxmod… #2380

Uh oh!

Conversation

yamaguchi1024 commented Jul 27, 2018

Uh oh!

phsft-bot commented Jul 27, 2018

Uh oh!

yamaguchi1024 commented Jul 27, 2018

Uh oh!

phsft-bot commented Jul 27, 2018

Uh oh!

yamaguchi1024 commented Jul 27, 2018

Uh oh!

phsft-bot commented Jul 27, 2018

Uh oh!

phsft-bot commented Jul 28, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Jul 31, 2018

Uh oh!

phsft-bot commented Jul 31, 2018

Uh oh!

yamaguchi1024 commented Jul 31, 2018

Uh oh!

phsft-bot commented Jul 31, 2018

Uh oh!

phsft-bot commented Jul 31, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Jul 31, 2018

Uh oh!

phsft-bot commented Aug 1, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Aug 1, 2018

Uh oh!

phsft-bot commented Aug 1, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Aug 1, 2018

Uh oh!

phsft-bot commented Aug 1, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Aug 2, 2018

Uh oh!

phsft-bot commented Aug 2, 2018

Uh oh!

phsft-bot commented Aug 3, 2018

Uh oh!

phsft-bot commented Aug 3, 2018

Failing tests:

Uh oh!

phsft-bot commented Aug 21, 2018

Uh oh!

phsft-bot commented Aug 21, 2018

Errors:

Failing tests:

Uh oh!

vgvassilev commented Nov 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants