Skip to content

Removed redundant -fmodule-map-file= compilation flag. #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vgvassilev merged 1 commit into from
May 9, 2017
Merged

Removed redundant -fmodule-map-file= compilation flag. #551

vgvassilev merged 1 commit into from
May 9, 2017

Conversation

@Teemperor
Copy link
Contributor

@Teemperor Teemperor commented May 5, 2017

We already have implicit module maps, so this module map
will be automatically discovered by clang.

@Teemperor
Removed redundant -fmodule-map-file= compilation flag.
27aa583 
We already have implicit module maps, so this module map
will be automatically discovered by clang.
@phsft-bot
Copy link

phsft-bot commented May 5, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=OFF -Dccache=ON

@Teemperor
Copy link
Contributor Author

Teemperor commented May 5, 2017

@phsft-bot build with compiler:clang_gcc62;extra_cmake_options:-Dcxxmodules=On -DCMAKE_VERBOSE_MAKEFILE:BOOL=On !

@phsft-bot
Copy link

phsft-bot commented May 5, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=OFF -Dccache=ON

@Teemperor
Copy link
Contributor Author

Teemperor commented May 5, 2017

@phsft-bot build with compiler:clang_gcc62;extra_cmake_options:-Dcxxmodules=On -Dccache=Off -DCMAKE_VERBOSE_MAKEFILE:BOOL=On !

@phsft-bot
Copy link

phsft-bot commented May 5, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=OFF -Dccache=ON

@vgvassilev
Copy link
Member

vgvassilev commented May 8, 2017

@phsft-bot build with compiler:clang_gcc62;extra_cmake_options:-Dcxxmodules=On -Dccache=Off -DCMAKE_VERBOSE_MAKEFILE:BOOL=On !

@Teemperor
Copy link
Contributor Author

Teemperor commented May 8, 2017

Build passes for me locally. Pls merge @vgvassilev

@vgvassilev vgvassilev merged commit fc8c10e into root-project:master May 9, 2017
@Teemperor Teemperor deleted the RemoveModuleMapFileFlag branch December 19, 2017 08:39
@phsft-bot phsft-bot mentioned this pull request Jul 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Teemperor @phsft-bot @vgvassilev