Cxx modules remove root maps

[vgvassilev]

No description provided.

[phsft-bot]

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

[vgvassilev]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on slc6/gcc62.
See console output.

[vgvassilev]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

[vgvassilev]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on slc6/gcc62.
See console output.

Errors:

• 633/1525 Test Run GL tests also in batch mode. #556: tutorial-r-DataFrame ..............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.43 sec
• 636/1525 Test [DOC] Update TDF release notes #557: tutorial-r-Function ...............................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.30 sec
• 730/1525 Test Extend TCanvasImp interface #622: tutorial-tree-jets ................................................................................***Failed Error regular expression found in output. Regex=[: error:] 51.40 sec

Failing tests:

• projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_execMixedBaseClass_v1
• projectroot.runtutorials.tutorial_unfold_testUnfold7b
• projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_execMixedBaseClass_v2
• projectroot.roottest.root.multicore.roottest_root_multicore_generate_imt_tree
• projectroot.math.mathcore.test.gtest_math_mathcore_test_stressMathCoreUnit
• projectroot.runtutorials.tutorial_dataframe_df002_dataModel
• projectroot.runtutorials.tutorial_dataframe_df102_NanoAODDimuonAnalysis
• projectroot.runtutorials.tutorial_graphs_graphpolar
• projectroot.runtutorials.tutorial_graphs_graphpolar2
• projectroot.runtutorials.tutorial_math_mathcoreVectorCollection

And 127 more

[vgvassilev]

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on slc6/gcc62.
See console output.

Warnings:

• include/TObject.h:140:24: warning: ‘virtual void TObject::Print(Option_t*) const’ was hidden [-Woverloaded-virtual]

[phsft-bot]

Starting build on ROOT-centos7/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -Dccache=ON
How to customize builds

[phsft-bot]

Build failed on mac1014/cxx17.
See console output.

[phsft-bot]

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

• projectroot.bindings.pyroot.test.pyunittests_pyroot_list_initialization
• projectroot.bindings.pyroot.test.pyunittests_pyroot_rvec
• projectroot.bindings.pyroot.test.pyunittests_pyroot_pretty_printing
• projectroot.bindings.pyroot.test.pyunittests_pyroot_array_interface
• projectroot.bindings.pyroot.test.pyunittests_pyroot_ttree_asmatrix
• projectroot.bindings.pyroot.test.pyunittests_pyroot_conversions
• projectroot.math.mathcore.test.gtest_math_mathcore_test_stressMathCoreUnit
• projectroot.tree.dataframe.test.pyunittests_dataframe_misc
• projectroot.tree.dataframe.test.pyunittests_dataframe_histograms
• projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_snapshot

And 1 more

[phsft-bot]

Build failed on ROOT-centos7/noimt.
See console output.

Errors:

• collect2: error: ld returned 1 exit status
• error: unable to read PCH file /mnt/build/jenkins/workspace/root-pullrequests-build/build/etc/allDict.cxx.pch: 'No such file or directory'

[vgvassilev]

@pcanal, could you give us a hand here?

This PR removes the generation of rootmap files when we have a module. It fails because of similar to this error:

Fatal in <TClass::SetUnloaded>: The TClass for ROOT::Math::SMatrix<double,4,3,ROOT::Math::MatRepStd<double,4,3> > is being unloaded when in state 3

aborting
#0  0x00007fe869e2a07a in __GI___waitpid (pid=12953, stat_loc=stat_loc
entry=0x7ffd87834410, options=options
entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:29
#1  0x00007fe869da2fbb in do_system (line=<optimized out>) at ../sysdeps/posix/system.c:148
#2  0x00007fe86af40302 in TUnixSystem::StackTrace() () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#3  0x00007fe86ae177ba in DefaultErrorHandler(int, bool, char const*, char const*) () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#4  0x00007fe86ae17152 in ErrorHandler () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#5  0x00007fe86ae2ddbe in TObject::Fatal(char const*, char const*, ...) const () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#6  0x00007fe86aee13b6 in TClass::SetUnloaded() () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#7  0x00007fe86ae94f94 in ROOT::RemoveClass(char const*) () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#8  0x00007fe86af00bef in ROOT::TGenericClassInfo::~TGenericClassInfo() () from /mnt/build/workspace/root-pullrequests-build/build/lib/libCore.so
#9  0x00007fe869d97ff8 in __run_exit_handlers (status=1, listp=0x7fe86a1225f8 <__exit_funcs>, run_list_atexit=run_list_atexit
entry=true) at exit.c:82

Here we are destroying a TGenericClassInfo object which has never been loaded. I would guess that without having rootmap files around we load less classes (i.e. only the ones we actually need). Could you give an example when this happens or even better tell how to fix it.

[vgvassilev]

@phsft-bot build just on ROOT-ubuntu16/rtcxxmod with flags -Dctest_test_exclude_none=on

[phsft-bot]

Starting build on ROOT-ubuntu16/rtcxxmod with flags -Dccache=ON -Dctest_test_exclude_none=on
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmkdir3PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm3PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm2PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmkdir1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmv2PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp2PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp5PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp4PrepareInput

And 272 more

[vgvassilev]

To reproduce:

cmake  -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DLLVM_BUILD_TYPE="RelWithDebInfo" -Dbuiltin_gsl="On" -Dpython="On" -Droottest="On" -Druntime_cxxmodules="On" -Dx11="Off" /home/vvassilev/workspace/sources/root
make -j8
. bin/thisroot.sh 
ctest -VV -R "roottest-root-meta-iotypeioname.*"

[vgvassilev]

@phsft-bot build just on ROOT-ubuntu16/rtcxxmod with flags -Dctest_test_exclude_none=on -DCMAKE_BUILD_TYPE=Debug -DLLVM_BUILD_TYPE=Debug

[phsft-bot]

Starting build on ROOT-ubuntu16/rtcxxmod with flags -Dccache=ON -Dctest_test_exclude_none=on -DCMAKE_BUILD_TYPE=Debug -DLLVM_BUILD_TYPE=Debug
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Failing tests:

• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm2PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmkdir1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmkdir3PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmkdir2PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootrm3PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootmv1PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp4PrepareInput
• projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_SimpleRootcp2PrepareInput

And 275 more