Extend TCanvasImp interface #622
Conversation
linev
commented
Jun 8, 2017
linev
commented
- let create TVirtualPadPainter via the TCanvasImp.
- handling of TCanvas::Update() can be perfromed in TCanvasImp
- let create TVirtualPadPainter via the TCanvasImp. - handling of TCanvas::Update() can be perfromed in TCanvasImp
|
Starting build on |
|
Build failed on mac1012/native. Failing tests: |
|
I will merge once the tests are over... |
|
Usual question - should I reformat original TCanvas code, which I kept as is. |
|
yes in this case, for 'just' the line changed (i.e. the travis recommendation). |
|
Done |
|
Starting build on |
Philippe, your command does not work for me. I tried: |
I do not understand logic behind. Sorry.
|
Starting build on |
|
@linev How does it fail? |
It says that there is nothing changed. |
|
Build failed on mac1012/native. Failing tests: |
|
Note: the two failing test (math and cling) are unrelated to this PR. |
|
Build failed on slc6/gcc62. Failing tests: |
|
@vgvassilev any ideas? |
graf2d/gpad/src/TCanvas.cxx
Outdated
| fPainter = new TPadPainter;//Do not need plugin manager for this! | ||
| else { | ||
| if (!UseGL() || fBatch) { | ||
| fPainter = !fCanvasImp ? 0 : fCanvasImp->CreatePadPainter(); |
There was a problem hiding this comment.
Is
if (fCanvasImp)
fPainter = fCanvasImp->CreatePadPainter();
maybe a more readable version of this code?
There was a problem hiding this comment.
maybe a more readable version of this code?
Done
6 participants
