Allow reading v5 TF1 that were stored memberwise in a TClonesArray. #3964

pcanal · 2019-06-14T17:58:37Z

Fixes ROOT-10161

phsft-bot · 2019-06-14T17:58:48Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

pcanal · 2019-06-14T17:58:59Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-06-14T17:59:08Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-14T17:59:21Z

Build failed on windows10/default.
See console output.

phsft-bot · 2019-06-14T18:13:14Z

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Warnings:

CMake Warning at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

projectroot.roottest.root.io.clones.roottest_root_io_clones_make

phsft-bot · 2019-06-14T18:18:40Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

projectroot.roottest.root.io.clones.roottest_root_io_clones_make

phsft-bot · 2019-06-14T18:25:30Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-14T18:25:43Z

Build failed on windows10/default.
See console output.

phsft-bot · 2019-06-14T18:34:16Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-14T18:48:54Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-14T18:49:09Z

Build failed on mac1014/cxx17.
See console output.

Errors:

CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:867 (message):

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

phsft-bot · 2019-06-14T18:49:11Z

Build failed on windows10/default.
See console output.

phsft-bot · 2019-06-14T19:01:58Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-14T19:25:43Z

Build failed on windows10/default.
See console output.

Warnings:

CMake Warning at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

phsft-bot · 2019-06-14T19:28:09Z

Build failed on ROOT-fedora27/noimt.
See console output.

Warnings:

CMake Warning at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

phsft-bot · 2019-06-14T19:29:14Z

Build failed on ROOT-fedora29/python3.
See console output.

Warnings:

CMake Warning at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

phsft-bot · 2019-06-14T19:45:50Z

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Warnings:

CMake Warning at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):
/mnt/build/workspace/root-pullrequests-build/root/hist/hist/src/TF1.cxx:145:12: warning: ‘R__RegisterTF1UpdaterTrigger’ defined but not used [-Wunused-variable]
/mnt/build/workspace/root-pullrequests-build/root/hist/hist/src/TFormula.cxx:236:12: warning: ‘R__RegisterTF1UpdaterTrigger’ defined but not used [-Wunused-variable]

Failing tests:

pcanal · 2019-06-17T16:46:24Z

the failure are real and due to a compiler bug which introduce (infinite) loop where there isn't ... Trying to narrow down and/or avoid the pattern provoking this ...

phsft-bot · 2019-06-17T19:01:57Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-17T19:03:04Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-17T19:22:40Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

projectroot.runtutorials.tutorial_fit_graph2dfit

phsft-bot · 2019-06-17T19:41:23Z

Build failed on windows10/default.
See console output.

Warnings:

CMake Warning at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

pcanal · 2019-06-17T23:06:21Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2019-06-17T23:06:31Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-17T23:25:19Z

Build failed on mac1014/cxx17.
See console output.

Errors:

804/1758 Test Updated gitignore for QtCreator files. #715: tutorial-v7-ntuple-ntpl004_dimuon .................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.33 sec

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

Failing tests:

phsft-bot · 2019-06-17T23:55:08Z

Build failed on windows10/default.
See console output.

Warnings:

CMake Warning at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:830 (message):

phsft-bot · 2019-06-18T16:45:43Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-18T17:11:04Z

Build failed on windows10/default.
See console output.

Warnings:

CMake Warning at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:836 (message):

phsft-bot · 2019-06-18T17:19:09Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:836 (message):

Failing tests:

projectroot.runtutorials.tutorial_v7_line.cxx

phsft-bot · 2019-06-18T17:32:30Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2019-06-18T18:01:18Z

Build failed on windows10/default.
See console output.

Warnings:

CMake Warning at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:836 (message):

phsft-bot · 2019-06-18T18:05:40Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

CMake Warning at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:836 (message):

Failing tests:

projectroot.runtutorials.tutorial_v7_line.cxx

Fixes ROOT-10161

For unknown reasons having a call to TF1::Update (which is inside the inline function TF1::SetParameters) leads gcc to add a non-existant jump back in the middle of the routine resulting in a defacto infinite loop. [i.e commenting out the call to Update remove the 'bad code injection'] The solution is to unroll/explicitly inline TF1::SetParameters and remove the call to Update (and also spread it to avoid duplicate conditional statement).

The ownership of the TGraphDelaunay (fDelaunay) is delegated to the histogram (fHistogram), whenever the later is deleted the former is also deleted but was leaving fDelaunay pointing to deleted memeory.

phsft-bot · 2019-06-18T22:59:55Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

pcanal · 2019-06-19T10:42:47Z

@couet @Axel-Naumann the failure on mac1014/cxx17 in tutorial/v7/line.cxx is unclear and has happened in a couple of other PR but is not easily reproducible (even on the machine with the failure).

pcanal requested a review from lmoneta as a code owner June 14, 2019 17:58

pcanal force-pushed the ROOT-10161 branch from b42a96c to 599e2bf Compare June 14, 2019 18:25

pcanal force-pushed the ROOT-10161 branch from 599e2bf to 4cf4570 Compare June 14, 2019 18:34

pcanal force-pushed the ROOT-10161 branch from a139fb6 to 1ea6baa Compare June 14, 2019 19:01

pcanal force-pushed the ROOT-10161 branch from 981657b to 8820096 Compare June 17, 2019 19:02

pcanal force-pushed the ROOT-10161 branch from 8820096 to 17dfa0f Compare June 18, 2019 16:45

pcanal force-pushed the ROOT-10161 branch from 17dfa0f to e4ad30f Compare June 18, 2019 17:32

pcanal added 4 commits June 18, 2019 17:59

Allow reading v5 TF1 that were stored memberwise in a TClonesArray.

0c608d9

Fixes ROOT-10161

TClonesArray::Expand* avoid nullptr dereference if object is invalid

255dad6

TGraph2D prevent random memory reads.

1982f62

The ownership of the TGraphDelaunay (fDelaunay) is delegated to the histogram (fHistogram), whenever the later is deleted the former is also deleted but was leaving fDelaunay pointing to deleted memeory.

pcanal force-pushed the ROOT-10161 branch from e4ad30f to 1982f62 Compare June 18, 2019 22:59

pcanal merged commit 0b16086 into root-project:master Jun 19, 2019

pcanal deleted the ROOT-10161 branch June 19, 2019 10:43

Allow reading v5 TF1 that were stored memberwise in a TClonesArray. #3964

Allow reading v5 TF1 that were stored memberwise in a TClonesArray. #3964

Uh oh!

Conversation

pcanal commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

pcanal commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Errors:

Warnings:

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 14, 2019

Warnings:

Failing tests:

Uh oh!

pcanal commented Jun 17, 2019

Uh oh!

phsft-bot commented Jun 17, 2019

Uh oh!

phsft-bot commented Jun 17, 2019

Uh oh!

phsft-bot commented Jun 17, 2019

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 17, 2019

Warnings:

Uh oh!

pcanal commented Jun 17, 2019

Uh oh!

phsft-bot commented Jun 17, 2019

Uh oh!

phsft-bot commented Jun 17, 2019

Errors:

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jun 17, 2019

Warnings:

Uh oh!

phsft-bot commented Jun 18, 2019

Uh oh!