Skip to content

Allow reading v5 TF1 that were stored memberwise in a TClonesArray. #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcanal merged 4 commits into from
Jun 19, 2019
Merged

Allow reading v5 TF1 that were stored memberwise in a TClonesArray. #3964

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c608d9
Allow reading v5 TF1 that were stored memberwise in a TClonesArray.
pcanal Jun 13, 2019
255dad6
TClonesArray::Expand* avoid nullptr dereference if object is invalid
pcanal Jun 14, 2019
7f3ac5f
Work-around gcc optimization bug.
pcanal Jun 17, 2019
1982f62
TGraph2D prevent random memory reads.
pcanal Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Work-around gcc optimization bug. 
For unknown reasons having a call to TF1::Update (which is inside the inline function
TF1::SetParameters) leads gcc to add a non-existant jump back in the middle of the
routine resulting in a defacto infinite loop.  [i.e commenting out the call to Update
remove the 'bad code injection']

The solution is to unroll/explicitly inline TF1::SetParameters and remove the call
to Update (and also spread it to avoid duplicate conditional statement).
  • Loading branch information
@pcanal
pcanal committed Jun 18, 2019
commit 7f3ac5f3bcd9a63c8a0750b868c29cf4ebd8938f
8 changes: 6 additions & 2 deletions hist/hist/src/TF1.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,18 @@ struct TF1v5Convert : public TF1 {
fnew.SetRange(from.fXmin, from.fXmax);
}
fnew.Copy(*this);
// need to set parameter values
if (from.GetParameters())
fFormula->SetParameters(from.GetParameters());
} else {
// case of a function pointers
fParams = new TF1Parameters(fNpar);
fName = from.GetName();
fTitle = from.GetTitle();
// need to set parameter values
if (from.GetParameters())
fParams->SetParameters(from.GetParameters());
}
// need to set parameter values
SetParameters(from.GetParameters());
// copy the other data members
fNpx = from.fNpx;
fType = (EFType)from.fType;
Expand Down