Skip to content

Conversation

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Jul 31, 2019

The copy constructor of TF1Convolution and TF1NormSum where usinog TF1::Clone for the contained TF1 pointers. TF1::Clone does not work when the TF1 objects are based on compiled functors and not formula.
Use now the correct TF1::Copy function to copy the contained objects.

This fixes the problem reported at https://root-forum.cern.ch/t/tf1convolution-zero-in-root-6-18/35421

lmoneta added 2 commits July 31, 2019 15:01
…jects. One needs to use TF1::Copy instead of TF1::Clone when copying the contained objects
… that the contained TF1 pointer can be of a derived class (e.g. TF2 or TF3)
@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Errors:

And 2 more

Failing tests:

And 2 more

@lmoneta
Copy link
Member Author

lmoneta commented Jul 31, 2019

@phsft-bot build!

@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@lmoneta lmoneta merged commit 8e348e9 into root-project:master Aug 1, 2019
@lmoneta lmoneta deleted the fix_copy_tf1convolution branch August 1, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants