Skip to content

Fixes regression and corresponding tests #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmoneta merged 3 commits into from
Jul 19, 2017
Merged

Fixes regression and corresponding tests #758

lmoneta merged 3 commits into from
Jul 19, 2017

Conversation

@xvallspl
Copy link
Contributor

@xvallspl xvallspl commented Jul 13, 2017

No description provided.

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Build failed on slc6/gcc49.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/math/mathcore/test/fit/testLogLExecPolicy.cxx:242:39: error: ‘seq’ was not declared in this scope

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Build failed on ubuntu14/native.
See console output.

Errors:

  • /mnt/build/workspace/root-pullrequests-build/root/math/mathcore/test/fit/testLogLExecPolicy.cxx:242:39: error: ‘seq’ was not declared in this scope

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Build failed on mac1012/native.
See console output.

Errors:

  • /Volumes/MacintoshHD2/ec/build/workspace/root-pullrequests-build/root/math/mathcore/test/fit/testLogLExecPolicy.cxx:242:39: error: use of undeclared identifier 'seq'

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

2 similar comments
@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Build failed on slc6/gcc49.
See console output.

Failing tests:

@vgvassilev
Copy link
Member

vgvassilev commented Jul 13, 2017

@phsft-bot build!

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 13, 2017

Build failed on slc6/gcc49.
See console output.

Errors:

  • ninja: error: loading 'build.ninja': No such file or directory

@vgvassilev
Copy link
Member

vgvassilev commented Jul 14, 2017

@phsft-bot build!

@phsft-bot
Copy link

phsft-bot commented Jul 14, 2017

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev
Copy link
Member

vgvassilev commented Jul 14, 2017

Could you address the travis complaints?

@phsft-bot
Copy link

phsft-bot commented Jul 14, 2017

Build failed on mac1012/native.
See console output.

Warnings:

  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]
  • include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]

Failing tests:

@xvallspl
Copy link
Contributor Author

xvallspl commented Jul 14, 2017 •
edited
Loading

@vgvassilev I can address the space before the comment text thing, but I don't agree with the other suggested changes (one liners or line splitters).

I'm building again on that mac to see if it fails again.

@xvallspl
Copy link
Contributor Author

xvallspl commented Jul 14, 2017

@phsft-bot build on mac1012/native

@phsft-bot
Copy link

phsft-bot commented Jul 14, 2017

Starting build on native/mac1012 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 14, 2017

Build failed on mac1012/native.
See console output.

Warnings:

  • /Volumes/MacintoshHD2/build/workspace/root-pullrequests-build/build/include/ROOT/TThreadedObject.hxx:74:55: warning: unused parameter 'd' [-Wunused-parameter]

Failing tests:

@xvallspl
Copy link
Contributor Author

xvallspl commented Jul 18, 2017

@phsft-bot build!

@phsft-bot
Copy link

phsft-bot commented Jul 18, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@lmoneta lmoneta merged commit 848be2c into root-project:master Jul 19, 2017
hshe824 pushed a commit to hshe824/root that referenced this pull request Aug 8, 2017
@xvallspl
Fixes regression and corresponding tests (root-project#758)
2c9f4dd 
* Reintroduce free function constructor

Should fix BinnedFitExecPolicy test errors

* Actually fail if the test result is wrong

* Remove dumb ifdef guard
@phsft-bot phsft-bot mentioned this pull request Aug 1, 2018
Closed
This was referenced Jul 31, 2019
Merged
Merged
@phsft-bot phsft-bot mentioned this pull request Mar 22, 2022
Merged
This was referenced Mar 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xvallspl @phsft-bot @vgvassilev @lmoneta